Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Unified Diff: chrome/browser/media/router/presentation_service_delegate_impl.cc

Issue 1466573002: Presentation API: implement renderer side of PresentationConnection.close(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/presentation_service_delegate_impl.cc
diff --git a/chrome/browser/media/router/presentation_service_delegate_impl.cc b/chrome/browser/media/router/presentation_service_delegate_impl.cc
index bc145d2d57daccb92b092bbb7ea530b914eeb863..0123d5024eed9c5b8f6333ef49f6fd173b35acbc 100644
--- a/chrome/browser/media/router/presentation_service_delegate_impl.cc
+++ b/chrome/browser/media/router/presentation_service_delegate_impl.cc
@@ -730,6 +730,21 @@ void PresentationServiceDelegateImpl::CloseSession(
DVLOG(1) << "No active route for: " << presentation_id;
return;
}
+
+ // TODO(mfoltz): implement CloseSession(). Probably rename CloseRoute()?
+ NOTIMPLEMENTED();
whywhat 2015/11/20 06:26:49 This can probably implemented similar to onPresent
mark a. foltz 2015/11/20 17:47:17 This should call router_->OnPresentationSessionDet
mlamouri (slow - plz ping) 2015/11/27 11:48:47 Rebased. I left the TODO. I will have a look in a
+}
+
+void PresentationServiceDelegateImpl::TerminateSession(
+ int render_process_id,
+ int render_frame_id,
+ const std::string& presentation_id) {
+ const MediaRoute::Id& route_id = frame_manager_->GetRouteId(
+ RenderFrameHostId(render_process_id, render_frame_id), presentation_id);
+ if (route_id.empty()) {
+ DVLOG(1) << "No active route for: " << presentation_id;
+ return;
+ }
router_->CloseRoute(route_id);
}

Powered by Google App Engine
This is Rietveld 408576698