Presentation API: implement renderer side of PresentationConnection.close().

chrome/browser/media/router/presentation_service_delegate_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media/router/presentation_service_delegate_impl.h"
 
 #include <string>
 
 #include "base/containers/scoped_ptr_hash_map.h"
 #include "base/containers/small_map.h"
@@ skipping 712 matching lines @@
 void PresentationServiceDelegateImpl::CloseSession(
     int render_process_id,
     int render_frame_id,
     const std::string& presentation_id) {
   const MediaRoute::Id& route_id = frame_manager_->GetRouteId(
       RenderFrameHostId(render_process_id, render_frame_id), presentation_id);
   if (route_id.empty()) {
     DVLOG(1) << "No active route for: " << presentation_id;
     return;
   }
+
+  // TODO(mfoltz): implement CloseSession(). Probably rename CloseRoute()?
+  NOTIMPLEMENTED();

[whywhat, 2015/11/20 06:26:49]

This can probably implemented similar to onPresentationConnectionDetached()? The
MR is notified that the MediaRoute is no longer attached to the page.

[mark a. foltz, 2015/11/20 17:47:17]

This should call router_->OnPresentationSessionDetached(route_id) to notify the
MRP that the connection is going away.  PresentationFrame::Reset() should
probably call CloseSession(route_id) as part of the frame-level cleanup to
create one code path for this.

Note that Derek just landed a patch last night that changes the APIs to this
file so you will want to rebase.

https://chromium.googlesource.com/chromium/src.git/+/f3e5a01a75bbdd97e5d218c4...

[mlamouri (slow - plz ping), 2015/11/27 11:48:47]

Rebased. I left the TODO. I will have a look in a follow-up but the intent of
this CL was to implement the renderer side, not implement the full feature.

+}
+
+void PresentationServiceDelegateImpl::TerminateSession(
+    int render_process_id,
+    int render_frame_id,
+    const std::string& presentation_id) {
+  const MediaRoute::Id& route_id = frame_manager_->GetRouteId(
+      RenderFrameHostId(render_process_id, render_frame_id), presentation_id);
+  if (route_id.empty()) {
+    DVLOG(1) << "No active route for: " << presentation_id;
+    return;
+  }
   router_->CloseRoute(route_id);
 }
 
 void PresentationServiceDelegateImpl::ListenForSessionMessages(
     int render_process_id,
     int render_frame_id,
     const content::PresentationSessionInfo& session,
     const content::PresentationSessionMessageCallback& message_cb) {
   frame_manager_->ListenForSessionMessages(
       RenderFrameHostId(render_process_id, render_frame_id), session,
@@ skipping 79 matching lines @@
 bool PresentationServiceDelegateImpl::HasScreenAvailabilityListenerForTest(
     int render_process_id,
     int render_frame_id,
     const MediaSource::Id& source_id) const {
   RenderFrameHostId render_frame_host_id(render_process_id, render_frame_id);
   return frame_manager_->HasScreenAvailabilityListenerForTest(
       render_frame_host_id, source_id);
 }
 
 }  // namespace media_router