third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl - Issue 1466563003: Make [TypeChecking=Interface] the default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl

Issue 1466563003: Make [TypeChecking=Interface] the default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.idl ('k') | third_party/WebKit/Source/modules/webmidi/MIDIOutput.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl

index 520650a1219ff1c06b5ef1ea3bad6fd41d035fb9..77b4600aec51129f29df77bf11ea1204393a6590 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl

@@ -41,11 +41,10 @@ typedef unrestricted float GLfloat;

typedef unrestricted float GLclampf;

[

- // FIXME: [DoNotCheckConstants] and [TypeChecking=Interface] should be applied

- // to members and not need to be put on implementing interface

+ // FIXME: [DoNotCheckConstants] should be applied to members and not need to

+ // be put on implementing interface

// DoNotCheckConstants, // need to put on implementing interface

NoInterfaceObject, // Always used on target of 'implements'

- // TypeChecking=Interface, // need to put on implementing interface

WillBeGarbageCollected,

] interface WebGLRenderingContextBase {