Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7412)

Unified Diff: chrome/browser/ui/android/chrome_http_auth_handler.h

Issue 1466473003: Do not show untrustworthy strings in the basic auth dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolve memory leak. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/chrome_http_auth_handler.h
diff --git a/chrome/browser/ui/android/chrome_http_auth_handler.h b/chrome/browser/ui/android/chrome_http_auth_handler.h
index 4be4031097d814311ab2f83366f539fbe6ed9b0e..1c560365da2a0e7b0838cfedfe62458436e9eb33 100644
--- a/chrome/browser/ui/android/chrome_http_auth_handler.h
+++ b/chrome/browser/ui/android/chrome_http_auth_handler.h
@@ -17,7 +17,8 @@
// by, e.g., showing the user a login dialog.
class ChromeHttpAuthHandler {
public:
- explicit ChromeHttpAuthHandler(const base::string16& explanation);
+ ChromeHttpAuthHandler(const base::string16& authority,
+ const base::string16& explanation);
~ChromeHttpAuthHandler();
// This must be called before using the object.
@@ -54,7 +55,7 @@ class ChromeHttpAuthHandler {
private:
LoginHandler* observer_;
base::android::ScopedJavaGlobalRef<jobject> java_chrome_http_auth_handler_;
- // e.g. "The server example.com:80 requires a username and password."
+ base::string16 authority_;
base::string16 explanation_;
DISALLOW_COPY_AND_ASSIGN(ChromeHttpAuthHandler);

Powered by Google App Engine
This is Rietveld 408576698