Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6771)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/app/generated_resources.grd

Issue 1466473003: Do not show untrustworthy strings in the basic auth dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolve memory leak. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/android/chrome_http_auth_handler.h » ('j') | chrome/browser/ui/android/chrome_http_auth_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index ea588c4357d5fd9ff1b33f701cbc2d9025fdabe6..df0550ab05a84eb3c9b55a9c594bc03d449fe5de 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -3434,18 +3434,15 @@ Even if you have downloaded files from this website before, the website might ha
<message name="IDS_LOGIN_DIALOG_TITLE" desc="String to be displayed in the title bar of the login prompt dialog" formatter_data="android_java">
Authentication Required
</message>
- <message name="IDS_LOGIN_DIALOG_DESCRIPTION" desc="String to be displayed in the login prompt dialog to explain what the user needs to do">
- The server <ph name="DOMAIN">$1<ex>google.com</ex></ph> requires a username and password. The server says: <ph name="REALM">$2<ex>opaque string</ex></ph>.
+ <message name="IDS_LOGIN_DIALOG_AUTHORITY" desc="String to be displayed in the login prompt dialog to explain that the user needs to log in, and the name of the web site">
+ <ph name="DOMAIN">$1<ex>google.com</ex></ph> requires a username and password.
</message>
- <message name="IDS_LOGIN_DIALOG_DESCRIPTION_NO_REALM" desc="String to be displayed in the login prompt dialog to explain what the user needs to do">
- The server <ph name="DOMAIN">$1<ex>google.com</ex></ph> requires a username and password.
- </message>
- <message name="IDS_LOGIN_DIALOG_DESCRIPTION_PROXY" desc="String to be displayed in the proxy login prompt dialog to explain what the user needs to do">
- The proxy <ph name="DOMAIN">$1<ex>google.com</ex></ph> requires a username and password. The proxy says: <ph name="REALM">$2<ex>opaque string</ex></ph>.
- </message>
- <message name="IDS_LOGIN_DIALOG_DESCRIPTION_PROXY_NO_REALM" desc="String to be displayed in the proxy login prompt dialog to explain what the user needs to do">
+ <message name="IDS_LOGIN_DIALOG_PROXY_AUTHORITY" desc="String to be displayed in the proxy login prompt dialog to explain that the user needs to log in, and the name of the proxy">
The proxy <ph name="DOMAIN">$1<ex>google.com</ex></ph> requires a username and password.
</message>
+ <message name="IDS_LOGIN_DIALOG_DESCRIPTION_NOT_SECURE" desc="String to be displayed in the login prompt to explain that the web site is not secure">
+ The connection to this site is not secure.
msw 2015/11/20 19:15:07 nit: is there a similar existing string that we co
palmer 2015/11/20 19:33:48 Done.
+ </message>
<message name="IDS_LOGIN_DIALOG_USERNAME_FIELD" desc="The label of the username field in the login prompt dialog" formatter_data="android_java">
User Name:
</message>
« no previous file with comments | « no previous file | chrome/browser/ui/android/chrome_http_auth_handler.h » ('j') | chrome/browser/ui/android/chrome_http_auth_handler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698