Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1466473002: Fix for closure compile after chrome_extensions.js externs update. (Closed)

Created:
5 years, 1 month ago by michaelpg
Modified:
5 years, 1 month ago
Reviewers:
Lambros, Dan Beam, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for closure compile after chrome_extensions.js externs update. https://codereview.chromium.org/1457993002 broke the closure compile. BUG=556394 Committed: https://crrev.com/60b223b6b13f89e4e4c466d154cb9bd3bcbb8890 Cr-Commit-Position: refs/heads/master@{#360982}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M remoting/webapp/js_proto/chrome_proto.js View 2 chunks +1 line, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
michaelpg
PTAL.
5 years, 1 month ago (2015-11-19 20:56:37 UTC) #4
Dan Beam
lgtm
5 years, 1 month ago (2015-11-19 21:30:50 UTC) #6
Jamie
lgtm
5 years, 1 month ago (2015-11-21 00:34:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466473002/1
5 years, 1 month ago (2015-11-21 00:37:07 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-21 01:37:08 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-21 01:38:38 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60b223b6b13f89e4e4c466d154cb9bd3bcbb8890
Cr-Commit-Position: refs/heads/master@{#360982}

Powered by Google App Engine
This is Rietveld 408576698