Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1457993002: VideoPlayer: VideoPlayer: Fix calculation of window size. (Closed)

Created:
5 years, 1 month ago by fukino
Modified:
5 years, 1 month ago
Reviewers:
mtomasz
CC:
chromium-reviews, extensions-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, chromium-apps-reviews_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VideoPlayer: VideoPlayer: Fix calculation of window size. This is a reland of crrev.com/1451143002, with updating externs file. The diff in externs has already been included in upstream (cl/108204037) New MD player uses system header, so we need to set inner window size rather than outer one. Along with the fix, we moved to innerBounds and outerBounds since resizeTo and moveTo is deprecated. BUG=556394 TEST=manually Committed: https://crrev.com/19aafae1d230b295b6cdc23f0d936ef9f585ea23 Cr-Commit-Position: refs/heads/master@{#360511}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M third_party/closure_compiler/externs/chrome_extensions.js View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/file_manager/video_player/js/video_player.js View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
fukino
Tomasz, could you take a look (again)?
5 years, 1 month ago (2015-11-19 02:33:49 UTC) #2
mtomasz
lgtm
5 years, 1 month ago (2015-11-19 02:35:09 UTC) #4
fukino
On 2015/11/19 02:35:09, mtomasz wrote: > lgtm Thank you!
5 years, 1 month ago (2015-11-19 03:11:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457993002/1
5 years, 1 month ago (2015-11-19 03:12:20 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 03:17:25 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/19aafae1d230b295b6cdc23f0d936ef9f585ea23 Cr-Commit-Position: refs/heads/master@{#360511}
5 years, 1 month ago (2015-11-19 03:18:40 UTC) #9
michaelpg
On 2015/11/19 03:18:40, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
5 years, 1 month ago (2015-11-19 20:57:19 UTC) #10
Dan Beam
On 2015/11/19 20:57:19, michaelpg wrote: > On 2015/11/19 03:18:40, commit-bot: I haz the power wrote: ...
5 years, 1 month ago (2015-11-19 21:30:33 UTC) #11
fukino
5 years, 1 month ago (2015-11-20 00:55:49 UTC) #12
Message was sent while issue was closed.
On 2015/11/19 21:30:33, Dan Beam wrote:
> On 2015/11/19 20:57:19, michaelpg wrote:
> > On 2015/11/19 03:18:40, commit-bot: I haz the power wrote:
> > > Patchset 1 (id:??) landed as
> > > https://crrev.com/19aafae1d230b295b6cdc23f0d936ef9f585ea23
> > > Cr-Commit-Position: refs/heads/master@{#360511}
> > 
> > when you update externs, please grep for other uses
> > https://codereview.chromium.org/1466473002/
> 
> or just run closure

I'm sorry...
I'll make sure to check existing definitions and run closure locally when I
update common externs in the future.

Powered by Google App Engine
This is Rietveld 408576698