Loads the logo image to the speech UI in app-list.

Loads the logo image to the speech UI in app-list.

BUG=313904
R=xiyuan@chromium.org, oshima@chromium.org
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249328

[oshima, 2014-02-06 01:05:41]

https://codereview.chromium.org/146643004/diff/1/ui/app_list/speech_ui_model.h
File ui/app_list/speech_ui_model.h (right):

https://codereview.chromium.org/146643004/diff/1/ui/app_list/speech_ui_model....
ui/app_list/speech_ui_model.h:35: void set_logo(const gfx::ImageSkia& logo) {
logo_ = logo; }
do you really need this in model? Isn't it simpler to just do "ifdef
GOOGLE_CHROME_BUILD)" in SpeechView?

[Jun Mukai, 2014-02-06 01:10:13]

https://codereview.chromium.org/146643004/diff/1/ui/app_list/speech_ui_model.h
File ui/app_list/speech_ui_model.h (right):

https://codereview.chromium.org/146643004/diff/1/ui/app_list/speech_ui_model....
ui/app_list/speech_ui_model.h:35: void set_logo(const gfx::ImageSkia& logo) {
logo_ = logo; }
On 2014/02/06 01:05:41, oshima wrote:
> do you really need this in model? Isn't it simpler to just do "ifdef
> GOOGLE_CHROME_BUILD)" in SpeechView?

SpeechView is in ui/app_list which can't depend on the files in
chrome/app/theme.

[xiyuan, 2014-02-06 01:14:23]

lgtm

[oshima, 2014-02-06 01:16:23]

On 2014/02/06 01:10:13, Jun Mukai wrote:
> https://codereview.chromium.org/146643004/diff/1/ui/app_list/speech_ui_model.h
> File ui/app_list/speech_ui_model.h (right):
> 
>
https://codereview.chromium.org/146643004/diff/1/ui/app_list/speech_ui_model....
> ui/app_list/speech_ui_model.h:35: void set_logo(const gfx::ImageSkia& logo) {
> logo_ = logo; }
> On 2014/02/06 01:05:41, oshima wrote:
> > do you really need this in model? Isn't it simpler to just do "ifdef
> > GOOGLE_CHROME_BUILD)" in SpeechView?
> 
> SpeechView is in ui/app_list which can't depend on the files in
> chrome/app/theme.

Ah I see. lgtm then.

[Jun Mukai, 2014-02-06 01:19:24]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-02-06 01:24:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/146643004/1

[commit-bot: I haz the power, 2014-02-06 10:13:46]

Change committed as 249328