chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm - Issue 1466333004: mac: Fix unit test crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm

Issue 1466333004: mac: Fix unit test crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm

index e0627c79234b08c8e185f8bad54b76b7cebbfa46..b4249c1dcce4309ea4bbfb0cb92077242916c7f5 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm

@@ -284,8 +284,9 @@ void OmniboxPopupViewMac::PositionPopup(const CGFloat matrixHeight) {

// |popup_| gets redrawn once the animation completes. See

// http://crbug.com/538590 and http://crbug.com/551007 .

if (base::mac::IsOSElCapitanOrLater()) {

+ NSWindow* popup = popup_.get();

Mark Mentovai 2015/11/30 18:33:59 Aha, tricky!

[[NSAnimationContext currentContext] setCompletionHandler:^{

- [popup_ display];

+ [popup display];

}];

}

[[popup_ animator] setFrame:popup_frame display:YES];

« no previous file with comments | « no previous file | no next file » | no next file with comments »