Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: base/allocator/BUILD.gn

Issue 1466173002: Fix the `sizes` regressions in Linux GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@linux_x64_2
Patch Set: just switch //base/allocator:tcmalloc and //components/translate/content/browser to static libs Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/translate/content/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/allocator/BUILD.gn
diff --git a/base/allocator/BUILD.gn b/base/allocator/BUILD.gn
index 470f36328b33967576cc873a0f8766697394f9cf..04409d3948751200da848a94ff91a7e50d90b448 100644
--- a/base/allocator/BUILD.gn
+++ b/base/allocator/BUILD.gn
@@ -99,7 +99,10 @@ if (is_win) {
if (use_allocator == "tcmalloc") {
# tcmalloc currently won't compile on Android.
- source_set("tcmalloc") {
+ # TODO(crbug.com/559766) this should be a source_set but
+ # there are static initializers that get accidentally linked
+ # into chrome from vdso_support.cc that need to be addressed first.
+ static_library("tcmalloc") {
tcmalloc_dir = "//third_party/tcmalloc/chromium"
# Don't check tcmalloc's includes. These files include various files like
« no previous file with comments | « no previous file | components/translate/content/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698