components/translate/content/browser/BUILD.gn - Issue 1466173002: Fix the `sizes` regressions in Linux GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/content/browser/BUILD.gn

Issue 1466173002: Fix the `sizes` regressions in Linux GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@linux_x64_2

Patch Set: just switch //base/allocator:tcmalloc and //components/translate/content/browser to static libs Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/translate/content/browser/BUILD.gn

diff --git a/components/translate/content/browser/BUILD.gn b/components/translate/content/browser/BUILD.gn

index 4553d250edf1c7cfee37325fc071301693183a23..77090f623b55749ab0df4d813a77d535623431f5 100644

--- a/components/translate/content/browser/BUILD.gn

+++ b/components/translate/content/browser/BUILD.gn

@@ -4,7 +4,10 @@

import("//build/config/features.gni")

-source_set("browser") {

+static_library("browser") {

+ # TODO(crbug.com/565129) this should be a source_set but

+ # there are static initializers that get accidentally linked

+ # into chrome from that need to be addressed first.

sources = [

"browser_cld_data_provider.cc",

"browser_cld_data_provider.h",

« no previous file with comments | « base/allocator/BUILD.gn ('k') | tools/perf_expectations/perf_expectations.json » ('j') | no next file with comments »