Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: net/BUILD.gn

Issue 1466173002: Fix the `sizes` regressions in Linux GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@linux_x64_2
Patch Set: add TODOs Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/BUILD.gn
diff --git a/net/BUILD.gn b/net/BUILD.gn
index 7403fe2a68de1550f33ec7d126d2a2d62af58d8b..20d944fd299a4501679ddde723ed1d7e6dc7a24f 100644
--- a/net/BUILD.gn
+++ b/net/BUILD.gn
@@ -380,7 +380,10 @@ if (!is_nacl) {
net_shared_public_deps += [ "//native_client_sdk/src/libraries/nacl_io" ]
}
-component("net") {
+static_library("net") {
+ # TODO(crbug.com/559766) this should be a component but
+ # there are static initializers that get accidentally linked
+ # into chrome from that need to be addressed first.
sources = net_shared_sources
# Add back some sources that were otherwise filtered out.

Powered by Google App Engine
This is Rietveld 408576698