Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Unified Diff: extensions/renderer/BUILD.gn

Issue 1466173002: Fix the `sizes` regressions in Linux GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@linux_x64_2
Patch Set: add TODOs Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/BUILD.gn
diff --git a/extensions/renderer/BUILD.gn b/extensions/renderer/BUILD.gn
index 7ed31fea64b70b799d6fb3386b612abee72bead9..e0bc95c7a6aea75672d096e32006dd6dc8b7048a 100644
--- a/extensions/renderer/BUILD.gn
+++ b/extensions/renderer/BUILD.gn
@@ -8,7 +8,10 @@ import("//extensions/extensions.gni")
assert(enable_extensions)
# GYP version: extensions/extensions.gyp:extensions_renderer
-source_set("renderer") {
+static_library("renderer") {
+ # TODO(crbug.com/559766) this should be a source_set but
+ # there are static initializers that get accidentally linked
+ # into chrome from that need to be addressed first.
sources = rebase_path(extensions_gypi_values.extensions_renderer_sources,
".",
"//extensions")

Powered by Google App Engine
This is Rietveld 408576698