third_party/WebKit/Source/web/DateTimeChooserImpl.cpp - Issue 1466113002: Oilpan: move BaseChooserOnlyDateAndTimeInputType to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/DateTimeChooserImpl.cpp

Issue 1466113002: Oilpan: move BaseChooserOnlyDateAndTimeInputType to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add a prefinalizer Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/forms/MonthInputType.h ('K') | « third_party/WebKit/Source/web/DateTimeChooserImpl.h ('k') | third_party/WebKit/Source/web/ExternalDateTimeChooser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/DateTimeChooserImpl.cpp

diff --git a/third_party/WebKit/Source/web/DateTimeChooserImpl.cpp b/third_party/WebKit/Source/web/DateTimeChooserImpl.cpp

index 0d93ced6e3d8235a387e13b1d9182c51b739f61e..7bb8523cc0377246242d99b7a4c60ca9dc1adbdf 100644

--- a/third_party/WebKit/Source/web/DateTimeChooserImpl.cpp

+++ b/third_party/WebKit/Source/web/DateTimeChooserImpl.cpp

@@ -70,6 +70,7 @@ DateTimeChooserImpl::~DateTimeChooserImpl()

DEFINE_TRACE(DateTimeChooserImpl)

{

visitor->trace(m_chromeClient);

+ visitor->trace(m_client);

DateTimeChooser::trace(visitor);

}

@@ -204,7 +205,7 @@ void DateTimeChooserImpl::closePopup()

void DateTimeChooserImpl::didClosePopup()

{

ASSERT(m_client);

- m_popup = 0;

+ m_popup = nullptr;

m_client->didEndChooser();

}