Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: third_party/WebKit/Source/core/html/forms/MonthInputType.h

Issue 1466113002: Oilpan: move BaseChooserOnlyDateAndTimeInputType to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add a prefinalizer Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/forms/MonthInputType.h
diff --git a/third_party/WebKit/Source/core/html/forms/MonthInputType.h b/third_party/WebKit/Source/core/html/forms/MonthInputType.h
index 3b1af1c71cb57bbec9bfe9a6febbd63f0e1afb81..fec9113b38ad05a4ca24bfbf3eb4475639553626 100644
--- a/third_party/WebKit/Source/core/html/forms/MonthInputType.h
+++ b/third_party/WebKit/Source/core/html/forms/MonthInputType.h
@@ -43,11 +43,14 @@ using BaseMonthInputType = BaseChooserOnlyDateAndTimeInputType;
#endif
class MonthInputType final : public BaseMonthInputType {
+ WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MonthInputType);
haraken 2015/11/21 17:10:22 I'm a bit confused. Why does this need to use USIN
sof 2015/11/21 17:26:20 It only needs it !ENABLE(INPUT_MULTIPLE_FIELDS_UI)
sof 2015/11/21 17:41:52 I'll make that more precise, at the cost of some #
public:
static PassRefPtrWillBeRawPtr<InputType> create(HTMLInputElement&);
+ DEFINE_INLINE_VIRTUAL_TRACE() { BaseMonthInputType::trace(visitor); }
private:
- MonthInputType(HTMLInputElement& element) : BaseMonthInputType(element) { }
+ explicit MonthInputType(HTMLInputElement& element) : BaseMonthInputType(element) { }
+
void countUsage() override;
const AtomicString& formControlType() const override;
double valueAsDate() const override;

Powered by Google App Engine
This is Rietveld 408576698