Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: third_party/WebKit/Source/core/html/forms/TimeInputType.h

Issue 1466113002: Oilpan: move BaseChooserOnlyDateAndTimeInputType to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add a prefinalizer Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/forms/TimeInputType.h
diff --git a/third_party/WebKit/Source/core/html/forms/TimeInputType.h b/third_party/WebKit/Source/core/html/forms/TimeInputType.h
index 25192ddb3423b151f743b71bf76565dd4edcc081..ca6bf489a3baf999375d6f5f771edf0b861470b1 100644
--- a/third_party/WebKit/Source/core/html/forms/TimeInputType.h
+++ b/third_party/WebKit/Source/core/html/forms/TimeInputType.h
@@ -43,11 +43,14 @@ using BaseTimeInputType = BaseChooserOnlyDateAndTimeInputType;
#endif
class TimeInputType final : public BaseTimeInputType {
+ WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(TimeInputType);
public:
static PassRefPtrWillBeRawPtr<InputType> create(HTMLInputElement&);
+ DEFINE_INLINE_VIRTUAL_TRACE() { BaseTimeInputType::trace(visitor); }
private:
- TimeInputType(HTMLInputElement&);
+ explicit TimeInputType(HTMLInputElement&);
+
void countUsage() override;
const AtomicString& formControlType() const override;
Decimal defaultValueForStepUp() const override;
@@ -56,8 +59,8 @@ private:
bool setMillisecondToDateComponents(double, DateComponents*) const override;
void warnIfValueIsInvalid(const String&) const override;
String localizeValue(const String&) const override;
-#if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
+#if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
// BaseMultipleFieldsDateAndTimeInputType functions
String formatDateTimeFieldsState(const DateTimeFieldsState&) const override;
void setupLayoutParameters(DateTimeEditElement::LayoutParameters&, const DateComponents&) const override;

Powered by Google App Engine
This is Rietveld 408576698