Oilpan: move BaseChooserOnlyDateAndTimeInputType to the heap.

third_party/WebKit/Source/core/html/forms/MonthInputType.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 25 matching lines @@
 
 namespace blink {
 
 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
 using BaseMonthInputType = BaseMultipleFieldsDateAndTimeInputType;
 #else
 using BaseMonthInputType = BaseChooserOnlyDateAndTimeInputType;
 #endif
 
 class MonthInputType final : public BaseMonthInputType {
+    WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MonthInputType);

[haraken, 2015/11/21 17:10:22]

I'm a bit confused. Why does this need to use USING_GC_MIXIN? Both
BaseMultipleFieldsDateAndTimeInputType and BaseChooserOnlyDateAndTimeInputType
inherits from GarbageCollected and no mixin class is inherited by
MonthInputType...

(I think I'm missing something.)

[sof, 2015/11/21 17:26:20]

It only needs it !ENABLE(INPUT_MULTIPLE_FIELDS_UI) for DateTimeChooserClient.

[sof, 2015/11/21 17:41:52]

I'll make that more precise, at the cost of some #if-ery.

 public:
     static PassRefPtrWillBeRawPtr<InputType> create(HTMLInputElement&);
+    DEFINE_INLINE_VIRTUAL_TRACE() { BaseMonthInputType::trace(visitor); }
 
 private:
-    MonthInputType(HTMLInputElement& element) : BaseMonthInputType(element) { }
+    explicit MonthInputType(HTMLInputElement& element) : BaseMonthInputType(element) { }
+
     void countUsage() override;
     const AtomicString& formControlType() const override;
     double valueAsDate() const override;
     String serializeWithMilliseconds(double) const override;
     Decimal parseToNumber(const String&, const Decimal&) const override;
     Decimal defaultValueForStepUp() const override;
     StepRange createStepRange(AnyStepHandling) const override;
     bool parseToDateComponentsInternal(const String&, DateComponents*) const override;
     bool setMillisecondToDateComponents(double, DateComponents*) const override;
     bool canSetSuggestedValue() override;
 
 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
     // BaseMultipleFieldsDateAndTimeInputType functions
     String formatDateTimeFieldsState(const DateTimeFieldsState&) const override;
     void setupLayoutParameters(DateTimeEditElement::LayoutParameters&, const DateComponents&) const override;
     bool isValidFormat(bool hasYear, bool hasMonth, bool hasWeek, bool hasDay, bool hasAMPM, bool hasHour, bool hasMinute, bool hasSecond) const override;
 #endif
 };
 
 } // namespace blink
 
 #endif // MonthInputType_h