third_party/WebKit/Source/core/html/forms/DateInputType.h - Issue 1466113002: Oilpan: move BaseChooserOnlyDateAndTimeInputType to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/DateInputType.h

Issue 1466113002: Oilpan: move BaseChooserOnlyDateAndTimeInputType to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add a prefinalizer Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp ('K') | « third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp ('k') | third_party/WebKit/Source/core/html/forms/DateTimeChooserClient.h » ('j') | third_party/WebKit/Source/core/html/forms/MonthInputType.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/DateInputType.h

diff --git a/third_party/WebKit/Source/core/html/forms/DateInputType.h b/third_party/WebKit/Source/core/html/forms/DateInputType.h

index 38002ce531509436d7675bec9462eda2f673991d..b85f5a7eb2ee3d3352659ebb8b13a0f9309a4017 100644

--- a/third_party/WebKit/Source/core/html/forms/DateInputType.h

+++ b/third_party/WebKit/Source/core/html/forms/DateInputType.h

@@ -43,11 +43,14 @@ using BaseDateInputType = BaseChooserOnlyDateAndTimeInputType;

#endif

class DateInputType final : public BaseDateInputType {

+ WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(DateInputType);

public:

static PassRefPtrWillBeRawPtr<InputType> create(HTMLInputElement&);

+ DEFINE_INLINE_VIRTUAL_TRACE() { BaseDateInputType::trace(visitor); }

private:

- DateInputType(HTMLInputElement&);

+ explicit DateInputType(HTMLInputElement&);

void countUsage() override;

const AtomicString& formControlType() const override;

StepRange createStepRange(AnyStepHandling) const override;