Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: third_party/WebKit/Source/core/html/forms/TimeInputType.h

Issue 1466113002: Oilpan: move BaseChooserOnlyDateAndTimeInputType to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add a prefinalizer Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 25 matching lines...) Expand all
36 36
37 namespace blink { 37 namespace blink {
38 38
39 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI) 39 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
40 using BaseTimeInputType = BaseMultipleFieldsDateAndTimeInputType; 40 using BaseTimeInputType = BaseMultipleFieldsDateAndTimeInputType;
41 #else 41 #else
42 using BaseTimeInputType = BaseChooserOnlyDateAndTimeInputType; 42 using BaseTimeInputType = BaseChooserOnlyDateAndTimeInputType;
43 #endif 43 #endif
44 44
45 class TimeInputType final : public BaseTimeInputType { 45 class TimeInputType final : public BaseTimeInputType {
46 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(TimeInputType);
46 public: 47 public:
47 static PassRefPtrWillBeRawPtr<InputType> create(HTMLInputElement&); 48 static PassRefPtrWillBeRawPtr<InputType> create(HTMLInputElement&);
49 DEFINE_INLINE_VIRTUAL_TRACE() { BaseTimeInputType::trace(visitor); }
48 50
49 private: 51 private:
50 TimeInputType(HTMLInputElement&); 52 explicit TimeInputType(HTMLInputElement&);
53
51 void countUsage() override; 54 void countUsage() override;
52 const AtomicString& formControlType() const override; 55 const AtomicString& formControlType() const override;
53 Decimal defaultValueForStepUp() const override; 56 Decimal defaultValueForStepUp() const override;
54 StepRange createStepRange(AnyStepHandling) const override; 57 StepRange createStepRange(AnyStepHandling) const override;
55 bool parseToDateComponentsInternal(const String&, DateComponents*) const ove rride; 58 bool parseToDateComponentsInternal(const String&, DateComponents*) const ove rride;
56 bool setMillisecondToDateComponents(double, DateComponents*) const override; 59 bool setMillisecondToDateComponents(double, DateComponents*) const override;
57 void warnIfValueIsInvalid(const String&) const override; 60 void warnIfValueIsInvalid(const String&) const override;
58 String localizeValue(const String&) const override; 61 String localizeValue(const String&) const override;
62
59 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI) 63 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
60
61 // BaseMultipleFieldsDateAndTimeInputType functions 64 // BaseMultipleFieldsDateAndTimeInputType functions
62 String formatDateTimeFieldsState(const DateTimeFieldsState&) const override; 65 String formatDateTimeFieldsState(const DateTimeFieldsState&) const override;
63 void setupLayoutParameters(DateTimeEditElement::LayoutParameters&, const Dat eComponents&) const override; 66 void setupLayoutParameters(DateTimeEditElement::LayoutParameters&, const Dat eComponents&) const override;
64 bool isValidFormat(bool hasYear, bool hasMonth, bool hasWeek, bool hasDay, b ool hasAMPM, bool hasHour, bool hasMinute, bool hasSecond) const override; 67 bool isValidFormat(bool hasYear, bool hasMonth, bool hasWeek, bool hasDay, b ool hasAMPM, bool hasHour, bool hasMinute, bool hasSecond) const override;
65 #endif 68 #endif
66 }; 69 };
67 70
68 } // namespace blink 71 } // namespace blink
69 72
70 #endif // TimeInputType_h 73 #endif // TimeInputType_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698