Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 14660008: Fix braindead Handle::is_identical_to (Closed)

Created:
7 years, 7 months ago by rossberg
Modified:
7 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Fix braindead Handle::is_identical_to R=mstarzinger@chromium.org BUG= Committed: http://code.google.com/p/v8/source/detail?r=14568

Patch Set 1 #

Total comments: 2

Patch Set 2 : Also fix (and broaden) zap value assertions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M src/handles-inl.h View 1 2 chunks +7 lines, -8 lines 0 comments Download
M src/type-info.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
rossberg
7 years, 7 months ago (2013-05-07 11:41:04 UTC) #1
Michael Starzinger
Just for the record ... https://codereview.chromium.org/14660008/diff/1/src/handles-inl.h File src/handles-inl.h (right): https://codereview.chromium.org/14660008/diff/1/src/handles-inl.h#newcode57 src/handles-inl.h:57: reinterpret_cast<Address>(*location_) != kZapValue); As ...
7 years, 7 months ago (2013-05-07 11:58:37 UTC) #2
rossberg
https://codereview.chromium.org/14660008/diff/1/src/handles-inl.h File src/handles-inl.h (right): https://codereview.chromium.org/14660008/diff/1/src/handles-inl.h#newcode57 src/handles-inl.h:57: reinterpret_cast<Address>(*location_) != kZapValue); On 2013/05/07 11:58:37, Michael Starzinger wrote: ...
7 years, 7 months ago (2013-05-07 12:00:25 UTC) #3
Michael Starzinger
LGTM.
7 years, 7 months ago (2013-05-07 12:00:28 UTC) #4
rossberg
7 years, 7 months ago (2013-05-07 12:02:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r14568 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698