src/type-info.cc - Issue 14660008: Fix braindead Handle::is_identical_to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/type-info.cc

Issue 14660008: Fix braindead Handle::is_identical_to (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Also fix (and broaden) zap value assertions Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/type-info.cc

diff --git a/src/type-info.cc b/src/type-info.cc

index d29fd12ba0d4dbbc831c67a832c9e9ef2a6fb2a6..1757bee767381c68ddafbae97e9457592514fe19 100644

--- a/src/type-info.cc

+++ b/src/type-info.cc

@@ -67,7 +67,7 @@ TypeFeedbackOracle::TypeFeedbackOracle(Handle<Code> code,

isolate_(isolate),

zone_(zone) {

BuildDictionary(code);

- ASSERT(reinterpret_cast<Address>(*dictionary_.location()) != kHandleZapValue);

+ ASSERT(dictionary_->IsDictionary());

}

« no previous file with comments | « src/handles-inl.h ('k') | no next file » | no next file with comments »