Ensured that texture completeness takes into account base and max level

Ensured that texture completeness takes into account base and max level

BUG=295792
NOTRY=true

Committed: https://crrev.com/833361b84ab1c523f5a0bfde4ed04a297ce8f22a
Cr-Commit-Position: refs/heads/master@{#361373}

[bajones, 2015-11-20 22:59:58]

bajones@chromium.org changed reviewers:
+ kbr@chromium.org, zmo@chromium.org

[Ken Russell (switch to Gerrit), 2015-11-20 23:34:45]

kbr@chromium.org changed reviewers:
+ piman@chromium.org

[Ken Russell (switch to Gerrit), 2015-11-20 23:34:46]

This looks good, but what tests cover these code paths? +piman

[bajones, 2015-11-20 23:38:11]

On 2015/11/20 23:34:46, Ken Russell wrote:
> This looks good, but what tests cover these code paths? +piman

This fixes failures in
https://www.khronos.org/registry/webgl/sdk/tests/conformance2/textures/misc/t...
though the test could stand to be a little more fleshed out. (And I just noticed
the page title is wrong.)

[zmo, 2015-11-20 23:40:37]

I had a CL which got reverted due to an assertion in ANGLE (likely an ANGLE bug)

https://codereview.chromium.org/1412883002/

[Ken Russell (switch to Gerrit), 2015-11-21 00:11:10]

On 2015/11/20 23:40:37, zmo wrote:
> I had a CL which got reverted due to an assertion in ANGLE (likely an ANGLE
bug)
> 
> https://codereview.chromium.org/1412883002/

On the whole it looks to me like we should re-land
https://codereview.chromium.org/1412883002/ and suppress the failures until
they're fixed.

[bajones, 2015-11-21 00:13:40]

On 2015/11/21 00:11:10, Ken Russell wrote:
> On 2015/11/20 23:40:37, zmo wrote:
> > I had a CL which got reverted due to an assertion in ANGLE (likely an ANGLE
> bug)
> > 
> > https://codereview.chromium.org/1412883002/
> 
> On the whole it looks to me like we should re-land
> https://codereview.chromium.org/1412883002/ and suppress the failures until
> they're fixed.

I'm going to pull in zmo@'s fix (since his seems more complete) and check it out
on OSX to see if can identify what that failure was, then we'll push it with an
expectation for the ANGLE failure.

[bajones, 2015-11-23 22:45:14]

Updated CL. This is now mostly a copy of zmo@'s http://crrev.com/1412883002/ but
I've added the driver workaround on OSX to account for the newly discovered
issues with glGenerateMipmap and texture base level. (http://crbug.com/560499)

Please take another look!

[zmo, 2015-11-23 23:14:46]

zmo@google.com changed reviewers:
+ zmo@google.com

[zmo, 2015-11-23 23:14:47]

Great work to pin down the mac driver bug!

Could you please file a bug to Apple?

LGTM

https://codereview.chromium.org/1465993003/diff/40001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/1465993003/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:5014: tex->GetLevelType(target,
tex->base_level(), &type, &internal_format)) {
nit: the last condition is unnecessary because CanGenerateMipmaps() above should
already make sure it always returns true.

https://codereview.chromium.org/1465993003/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:5024: glTexImage2D(target, 0,
internal_format, 0, 0, 0, format, type, nullptr);
Could you please add a note that this might have side effects because the
texture level might have switched from uninitialized to initialized to size(0,
0) , but hopefully command buffer will intercept most calls that are affected?

[bajones, 2015-11-23 23:20:51]

On 2015/11/23 23:14:47, zmo wrote:
> Great work to pin down the mac driver bug!
> 
> Could you please file a bug to Apple?

Apple Bug#: 23650857, the contents of which are copied into
http://crbug.com/560499
 
> Could you please add a note that this might have side effects because the
> texture level might have switched from uninitialized to initialized to size(0,
> 0) , but hopefully command buffer will intercept most calls that are affected?

Done, thanks for the suggestion.

[Zhenyao Mo, 2015-11-23 23:22:46]

LGTM

[bajones, 2015-11-23 23:23:09]

The CQ bit was checked by bajones@chromium.org

[bajones, 2015-11-23 23:23:10]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@google.com
Link to the patchset: https://codereview.chromium.org/1465993003/#ps60001
(title: "Added comment suggested by zmo@")

[commit-bot: I haz the power, 2015-11-23 23:25:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1465993003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1465993003/60001

[commit-bot: I haz the power, 2015-11-23 23:53:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-23 23:53:33]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Ken Russell (switch to Gerrit), 2015-11-24 00:32:26]

I defer review to zmo@.

[bajones, 2015-11-24 00:57:47]

The CQ bit was checked by bajones@chromium.org

[bajones, 2015-11-24 00:57:48]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@google.com,
zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/1465993003/#ps80001
(title: "Fixing compiler warnings")

[commit-bot: I haz the power, 2015-11-24 00:59:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1465993003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1465993003/80001

[commit-bot: I haz the power, 2015-11-24 03:41:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 03:41:33]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bajones, 2015-11-24 04:29:30]

The CQ bit was checked by bajones@chromium.org

[commit-bot: I haz the power, 2015-11-24 04:30:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1465993003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1465993003/80001

[commit-bot: I haz the power, 2015-11-24 05:55:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 05:55:06]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bajones, 2015-11-24 16:54:39]

Description was changed from

==========
Ensured that texture completeness takes into account base and max level

BUG=295792
==========

to

==========
Ensured that texture completeness takes into account base and max level

BUG=295792
NOTRY=true
==========

[bajones, 2015-11-24 16:55:17]

On 2015/11/24 05:55:06, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Failure is obviously unrelated and persistent. NOTRY-ing.

[bajones, 2015-11-24 16:55:30]

The CQ bit was checked by bajones@chromium.org

[commit-bot: I haz the power, 2015-11-24 16:56:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1465993003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1465993003/80001

[commit-bot: I haz the power, 2015-11-24 17:06:18]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-11-24 17:07:26]

Patchset 5 (id:??) landed as
https://crrev.com/833361b84ab1c523f5a0bfde4ed04a297ce8f22a
Cr-Commit-Position: refs/heads/master@{#361373}