Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1465953003: Aura Android: ShowBrowserSignin is not defined for Android, use NOTIMPLEMENTED for now (Closed)

Created:
5 years, 1 month ago by bshe
Modified:
5 years, 1 month ago
Reviewers:
Finnur, mfomitchev
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Aura Android: ShowBrowserSignin is not defined for Android, use NOTIMPLEMENTED for now BUG=557285 Committed: https://crrev.com/b21a4e021fd5e71ecd0a55861f3500f007507986 Cr-Commit-Position: refs/heads/master@{#361133}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 49863002 Patch 1

Messages

Total messages: 12 (4 generated)
bshe
Hi Mikhail. Do you mind to take a look at this CL? Thanks!
5 years, 1 month ago (2015-11-20 22:28:29 UTC) #3
mfomitchev
LGTM
5 years, 1 month ago (2015-11-20 22:34:57 UTC) #4
bshe
+finnur for owners Thanks!
5 years, 1 month ago (2015-11-23 14:18:22 UTC) #6
Finnur
LGTM
5 years, 1 month ago (2015-11-23 16:29:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465953003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465953003/20001
5 years, 1 month ago (2015-11-23 16:40:41 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-23 17:36:16 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/b21a4e021fd5e71ecd0a55861f3500f007507986 Cr-Commit-Position: refs/heads/master@{#361133}
5 years, 1 month ago (2015-11-23 17:37:52 UTC) #11
bshe
4 years, 11 months ago (2016-01-05 19:38:18 UTC) #12
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1561723002/ by bshe@chromium.org.

The reason for reverting is: We dont need to support Aura Android at current
stage. Revert related code..

Powered by Google App Engine
This is Rietveld 408576698