Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 1465793005: Pass CapabilityFilter via CreateInstanceForHandle (Closed)

Created:
5 years, 1 month ago by Ben Goodger (Google)
Modified:
5 years ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass CapabilityFilter via CreateInstanceForHandle http://crbug.com/555392 Committed: https://crrev.com/6fbb41395a587c506cbf3bad18bcd89dec5c1803 Cr-Commit-Position: refs/heads/master@{#361255}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 3

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -63 lines) Patch
M content/browser/mojo/mojo_shell_client_host.cc View 1 2 chunks +10 lines, -2 lines 0 comments Download
M mojo/application/public/interfaces/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + mojo/application/public/interfaces/application_manager.mojom View 1 2 3 4 5 6 1 chunk +5 lines, -7 lines 0 comments Download
M mojo/mojo_base.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/mojo_shell.gyp View 1 2 2 chunks +0 lines, -12 lines 0 comments Download
M mojo/shell/BUILD.gn View 1 3 chunks +1 line, -8 lines 0 comments Download
M mojo/shell/application_manager.h View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/shell/application_manager.cc View 1 2 3 4 5 6 1 chunk +4 lines, -2 lines 0 comments Download
D mojo/shell/application_manager.mojom View 1 chunk +0 lines, -20 lines 0 comments Download
M mojo/shell/application_manager_apptest_driver.cc View 1 2 3 4 2 chunks +8 lines, -2 lines 0 comments Download
M mojo/shell/application_manager_apptest_target.cc View 1 2 3 4 2 chunks +1 line, -4 lines 0 comments Download
M mojo/shell/shell_application_delegate.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/shell/shell_application_delegate.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465793005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465793005/1
5 years, 1 month ago (2015-11-21 02:41:16 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_android/builds/82375) cast_shell_linux on ...
5 years, 1 month ago (2015-11-21 02:50:58 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465793005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465793005/40001
5 years, 1 month ago (2015-11-21 23:39:17 UTC) #6
Ben Goodger (Google)
5 years, 1 month ago (2015-11-22 04:31:48 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-22 04:52:06 UTC) #10
sky
https://codereview.chromium.org/1465793005/diff/60001/mojo/application/public/interfaces/application_manager.mojom File mojo/application/public/interfaces/application_manager.mojom (right): https://codereview.chromium.org/1465793005/diff/60001/mojo/application/public/interfaces/application_manager.mojom#newcode17 mojo/application/public/interfaces/application_manager.mojom:17: mojo.CapabilityFilter? filter); Document the capabilities a null filter gets. ...
5 years, 1 month ago (2015-11-22 15:27:31 UTC) #11
Ben Goodger (Google)
Removed the ability to pass a null filter. Will land after the other. PTAL https://codereview.chromium.org/1465793005/diff/60001/mojo/shell/application_manager.cc ...
5 years ago (2015-11-24 00:29:36 UTC) #12
sky
LGTM
5 years ago (2015-11-24 00:30:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465793005/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465793005/120001
5 years ago (2015-11-24 03:13:34 UTC) #15
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years ago (2015-11-24 04:44:28 UTC) #16
commit-bot: I haz the power
5 years ago (2015-11-24 04:45:28 UTC) #17
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/6fbb41395a587c506cbf3bad18bcd89dec5c1803
Cr-Commit-Position: refs/heads/master@{#361255}

Powered by Google App Engine
This is Rietveld 408576698