Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1175)

Unified Diff: mojo/application/public/interfaces/application_manager.mojom

Issue 1465793005: Pass CapabilityFilter via CreateInstanceForHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/application/public/interfaces/BUILD.gn ('k') | mojo/mojo_base.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/application/public/interfaces/application_manager.mojom
diff --git a/mojo/shell/application_manager.mojom b/mojo/application/public/interfaces/application_manager.mojom
similarity index 54%
rename from mojo/shell/application_manager.mojom
rename to mojo/application/public/interfaces/application_manager.mojom
index fbd2be76fea780f71899e4e72ae0834511b9e214..43edc81ede2a5ec0360f8c60ac553962d794701a 100644
--- a/mojo/shell/application_manager.mojom
+++ b/mojo/application/public/interfaces/application_manager.mojom
@@ -4,17 +4,15 @@
module mojo.shell.mojom;
+import "mojo/application/public/interfaces/shell.mojom";
+
interface ApplicationManager {
// Instructs the ApplicationManager to create an instance for an existing
// process at the other end of |channel|, and perform applicable
// initialization. This assumes the target process will bind the other end of
// channel to an implementation of ChildController and bind an Application
// request there.
- // TODO(beng): we should probably have an Identity mojom struct.
- // TODO(beng): for this to be used in production, it's going to have to take
- // a fully qualified Identity complete with CapabilityFilter,
- // otherwise child processes registered with the shell will be
- // able to request any application/service.
- // http://crbug.com/555392
- CreateInstanceForHandle(handle channel, string url);
+ CreateInstanceForHandle(handle channel,
+ string url,
+ mojo.CapabilityFilter filter);
};
« no previous file with comments | « mojo/application/public/interfaces/BUILD.gn ('k') | mojo/mojo_base.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698