Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 14657017: Start to disallow llvm.frameaddress and llvm.returnaddress in ABI checker. (Closed)

Created:
7 years, 7 months ago by jvoung (off chromium)
Modified:
7 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/pnacl-llvm.git@master
Visibility:
Public.

Description

Start to disallow llvm.frameaddress and llvm.returnaddress in ABI checker. They do not seem to be widely used by user code. * The boehm garbage collector library does reference __builtin_return_address under an ifdef, but it does not appear to be compiled in. * Mesa-7.6 uses __builtin_frame_address for u_debug_stack.c, but that also does not appear to be part of the built libraries. They expose stack/code addresses (at least the lower 32-bits of the address). As part of https://codereview.chromium.org/14619022/, we stopped considering the scons and gcc torture tests that use these intrinsics as meeting the stable ABI. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3378 R=dschuff@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=33da0d9

Patch Set 1 #

Patch Set 2 : add comments #

Patch Set 3 : x #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M lib/Analysis/NaCl/PNaClABIVerifyModule.cpp View 1 2 5 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jvoung (off chromium)
7 years, 7 months ago (2013-05-10 22:34:16 UTC) #1
Derek Schuff
lgtm
7 years, 7 months ago (2013-05-10 22:36:10 UTC) #2
jvoung (off chromium)
7 years, 7 months ago (2013-05-14 00:07:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r33da0d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698