Start to disallow llvm.frameaddress and llvm.returnaddress in ABI checker.

lib/Analysis/NaCl/PNaClABIVerifyModule.cpp

 //===- PNaClABIVerifyModule.cpp - Verify PNaCl ABI rules --------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // Verify module-level PNaCl ABI requirements (specifically those that do not
@@ skipping 111 matching lines @@
   }
 }
 
 bool PNaClABIVerifyModule::IsWhitelistedIntrinsic(const Function* F,
                                                   unsigned ID) {
   // Keep 3 categories of intrinsics for now.
   // (1) Allowed always
   // (2) Never allowed
   // (3) "Dev" intrinsics, which may or may not be allowed.
   // "Dev" intrinsics are controlled by the PNaClABIAllowDevIntrinsics flag.
-  // Please keep these sorted within each category.
+  // Please keep these sorted or grouped in a sensible way, within
+  // each category.
   switch(ID) {
     // Disallow by default.
     default: return false;
     // (1) Always allowed.
     case Intrinsic::invariant_end:
     case Intrinsic::invariant_start:
     case Intrinsic::lifetime_end:
     case Intrinsic::lifetime_start:
     case Intrinsic::memcpy:
     case Intrinsic::memmove:
     case Intrinsic::memset:
     case Intrinsic::nacl_read_tp:
     case Intrinsic::trap:
       return true;
 
     // (2) Known to be never allowed.
     case Intrinsic::not_intrinsic:
+    // Trampolines depend on a target-specific-sized/aligned buffer.
     case Intrinsic::adjust_trampoline:
+    case Intrinsic::init_trampoline:
+    // CXX exception handling is not stable.
     case Intrinsic::eh_dwarf_cfa:
     case Intrinsic::eh_return_i32:
     case Intrinsic::eh_return_i64:
     case Intrinsic::eh_sjlj_callsite:
     case Intrinsic::eh_sjlj_functioncontext:
     case Intrinsic::eh_sjlj_longjmp:
     case Intrinsic::eh_sjlj_lsda:
     case Intrinsic::eh_sjlj_setjmp:
     case Intrinsic::eh_typeid_for:
     case Intrinsic::eh_unwind_init:
-    case Intrinsic::init_trampoline:
+    // We do not want to expose addresses to the user.
+    case Intrinsic::frameaddress:
+    case Intrinsic::returnaddress:
+    // Not supporting stack protectors.
     case Intrinsic::stackprotector:
+    // Var-args handling is done w/out intrinsics.
     case Intrinsic::vacopy:
     case Intrinsic::vaend:
     case Intrinsic::vastart:
       return false;
 
     // (3) Dev intrinsics.
     case Intrinsic::dbg_declare:
     case Intrinsic::dbg_value:
       return PNaClABIAllowDevIntrinsics || PNaClABIAllowDebugMetadata;
     case Intrinsic::bswap: // Support via compiler_rt if arch doesn't have it?
     case Intrinsic::cos: // Rounding not defined: support with fast-math?
     case Intrinsic::ctlz: // Support via compiler_rt if arch doesn't have it?
     case Intrinsic::ctpop: // Support via compiler_rt if arch doesn't have it?
     case Intrinsic::cttz: // Support via compiler_rt if arch doesn't have it?
     case Intrinsic::exp: // Rounding not defined: support with fast-math?
     case Intrinsic::exp2: // Rounding not defined: support with fast-math?
     case Intrinsic::expect: // From __builtin_expect.
     case Intrinsic::flt_rounds:
-    case Intrinsic::frameaddress: // Support for 0-level or not?
     case Intrinsic::log: // Rounding not defined: support with fast-math?
     case Intrinsic::log2: // Rounding not defined: support with fast-math?
     case Intrinsic::log10: // Rounding not defined: support with fast-math?
     case Intrinsic::nacl_target_arch: // Used by translator self-build.
     case Intrinsic::pow: // Rounding is supposed to be the same as libm.
     case Intrinsic::powi: // Rounding not defined: support with fast-math?
     case Intrinsic::prefetch: // Could ignore if target doesn't support?
-    case Intrinsic::returnaddress: // Support for 0-level or not?
     case Intrinsic::sin: // Rounding not defined: support with fast-math?
     case Intrinsic::sqrt:
     case Intrinsic::stackrestore: // Used to support C99 VLAs.
     case Intrinsic::stacksave:
     // the *_with_overflow return struct types, so we'll need to fix these.
     case Intrinsic::sadd_with_overflow: // Introduced by -ftrapv
     case Intrinsic::ssub_with_overflow:
     case Intrinsic::uadd_with_overflow:
     case Intrinsic::usub_with_overflow:
     case Intrinsic::smul_with_overflow:
@@ skipping 111 matching lines @@
 }
 
 char PNaClABIVerifyModule::ID = 0;
 INITIALIZE_PASS(PNaClABIVerifyModule, "verify-pnaclabi-module",
                 "Verify module for PNaCl", false, true)
 
 ModulePass *llvm::createPNaClABIVerifyModulePass(
     PNaClABIErrorReporter *Reporter) {
   return new PNaClABIVerifyModule(Reporter);
 }