Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1465663002: Update XFA fpdfsdk to match master (Closed)

Created:
5 years, 1 month ago by Tom Sepez
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -113 lines) Patch
M core/include/fpdfapi/fpdf_parser.h View 1 chunk +29 lines, -1 line 1 comment Download
M fpdfsdk/src/fpdf_dataavail.cpp View 1 chunk +24 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfppo.cpp View 19 chunks +76 lines, -88 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/src/fsdk_annothandler.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fsdk_baseannot.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 3 chunks +1 line, -6 lines 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.cpp View 1 chunk +12 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, contains some code that failed to land.
5 years, 1 month ago (2015-11-19 23:57:36 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1465663002/diff/1/core/include/fpdfapi/fpdf_parser.h File core/include/fpdfapi/fpdf_parser.h (right): https://codereview.chromium.org/1465663002/diff/1/core/include/fpdfapi/fpdf_parser.h#newcode874 core/include/fpdfapi/fpdf_parser.h:874: // Must match PDF_DATA_* definitions in public/fpdf_dataavail.h, but ...
5 years, 1 month ago (2015-11-20 01:54:57 UTC) #3
Tom Sepez
5 years, 1 month ago (2015-11-20 17:45:29 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c7e4c4fe17f5c05671183a47541ea17f3dce75b5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698