Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Unified Diff: fpdfsdk/src/javascript/JS_Runtime.cpp

Issue 1465663002: Update XFA fpdfsdk to match master (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: fpdfsdk/src/javascript/JS_Runtime.cpp
diff --git a/fpdfsdk/src/javascript/JS_Runtime.cpp b/fpdfsdk/src/javascript/JS_Runtime.cpp
index 8f705d51faa68b0561d1b8cf6ae77ef0834a0945..ac6e99d1cd632a52f5bcd9b5a5acf03c2b34d185 100644
--- a/fpdfsdk/src/javascript/JS_Runtime.cpp
+++ b/fpdfsdk/src/javascript/JS_Runtime.cpp
@@ -29,9 +29,6 @@
#include "report.h"
#include "util.h"
-/* ------------------------------ CJS_Runtime ------------------------------ */
-v8::Global<v8::ObjectTemplate>& _getGlobalObjectTemplate(v8::Isolate* pIsolate);
-
// static
void IJS_Runtime::Initialize(unsigned int slot, void* isolate) {
FXJS_Initialize(slot, reinterpret_cast<v8::Isolate*>(isolate));
@@ -96,8 +93,7 @@ CJS_Runtime::~CJS_Runtime() {
for (auto* obs : m_observers)
obs->OnDestroyed();
- int size = m_ContextArray.GetSize();
- for (int i = 0; i < size; i++)
+ for (int i = 0; i < m_ContextArray.GetSize(); i++)
delete m_ContextArray.GetAt(i);
m_ContextArray.RemoveAll();
@@ -108,7 +104,6 @@ CJS_Runtime::~CJS_Runtime() {
if (m_isolateManaged)
m_isolate->Dispose();
- m_isolate = NULL;
}
void CJS_Runtime::DefineJSObjects() {

Powered by Google App Engine
This is Rietveld 408576698