[BackgroundSync] Split failed and succeeded cases of BackgroundSyncMetrics::CountRegister

[BackgroundSync] Split failed and succeeded cases of BackgroundSyncMetrics::CountRegister

Doing this prevents us from logging bogus values (for duplicate and could_fire) in case of failure.

BUG=559143
Committed: https://crrev.com/7736b6981249800392e4fdde226cd4cab2c1835e
Cr-Commit-Position: refs/heads/master@{#361194}

[jkarlin, 2015-11-20 15:03:47]

jkarlin@chromium.org changed reviewers:
+ iclelland@chromium.org

[jkarlin, 2015-11-20 15:03:48]

iclelland, PTAL, thanks!

[jkarlin, 2015-11-23 18:11:16]

On 2015/11/20 15:03:48, jkarlin wrote:
> iclelland, PTAL, thanks!

Ping!

[iclelland, 2015-11-23 19:54:59]

Sorry for the delay -- I looked at it on the plane last week, but never
submitted after landing :(

LGTM, with one comment nit

https://codereview.chromium.org/1465533006/diff/40001/content/browser/backgro...
File content/browser/background_sync/background_sync_metrics.cc (right):

https://codereview.chromium.org/1465533006/diff/40001/content/browser/backgro...
content/browser/background_sync/background_sync_metrics.cc:35: // status
static?
(ditto for the other three instances)

[jkarlin, 2015-11-23 20:00:46]

https://codereview.chromium.org/1465533006/diff/40001/content/browser/backgro...
File content/browser/background_sync/background_sync_metrics.cc (right):

https://codereview.chromium.org/1465533006/diff/40001/content/browser/backgro...
content/browser/background_sync/background_sync_metrics.cc:35: // status
On 2015/11/23 19:54:59, iclelland wrote:
> static?
> (ditto for the other three instances)

Oy. Thanks! Done.

[jkarlin, 2015-11-23 20:01:09]

The CQ bit was checked by jkarlin@chromium.org

[jkarlin, 2015-11-23 20:01:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
iclelland@chromium.org
Link to the patchset: https://codereview.chromium.org/1465533006/#ps60001
(title: "static")

[commit-bot: I haz the power, 2015-11-23 20:05:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1465533006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1465533006/60001

[commit-bot: I haz the power, 2015-11-23 21:50:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-23 21:51:56]

Patchset 4 (id:??) landed as
https://crrev.com/7736b6981249800392e4fdde226cd4cab2c1835e
Cr-Commit-Position: refs/heads/master@{#361194}