Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: content/browser/background_sync/background_sync_metrics.h

Issue 1465533006: [BackgroundSync] Split failed and succeeded cases of BackgroundSyncMetrics::CountRegister (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: static Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_sync/background_sync_metrics.h
diff --git a/content/browser/background_sync/background_sync_metrics.h b/content/browser/background_sync/background_sync_metrics.h
index 440ce3f4a427a8d717db86e7dab9b7545fb04dfe..2c958b3ae73117582c3ee53b4cd4403d405dd424 100644
--- a/content/browser/background_sync/background_sync_metrics.h
+++ b/content/browser/background_sync/background_sync_metrics.h
@@ -38,13 +38,17 @@ class BackgroundSyncMetrics {
static void RecordBatchSyncEventComplete(const base::TimeDelta& time,
int number_of_batched_sync_events);
- // Records the result of trying to register a sync. |could_fire| indicates
- // whether the conditions were sufficient for the sync to fire immediately at
- // the time it was registered.
- static void CountRegister(SyncPeriodicity periodicity,
- RegistrationCouldFire could_fire,
- RegistrationIsDuplicate registration_is_duplicate,
- BackgroundSyncStatus result);
+ // Records the result of successfully registering a sync. |could_fire|
+ // indicates whether the conditions were sufficient for the sync to fire
+ // immediately at the time it was registered.
+ static void CountRegisterSuccess(
+ SyncPeriodicity periodicity,
+ RegistrationCouldFire could_fire,
+ RegistrationIsDuplicate registration_is_duplicate);
+
+ // Records the status of a failed sync registration.
+ static void CountRegisterFailure(SyncPeriodicity periodicity,
+ BackgroundSyncStatus status);
// Records the result of trying to unregister a sync.
static void CountUnregister(SyncPeriodicity periodicity,
« no previous file with comments | « content/browser/background_sync/background_sync_manager.cc ('k') | content/browser/background_sync/background_sync_metrics.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698