Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 1465503002: Revert of CHECK that URLRequestJobs are not orphaned while blocked by extensions. (Closed)

Created:
5 years, 1 month ago by davidben
Modified:
5 years, 1 month ago
Reviewers:
Devlin, mmenke
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of CHECK that URLRequestJobs are not orphaned while blocked by extensions. (patchset #2 id:20001 of https://codereview.chromium.org/1337113004/ ) Reason for revert: https://crbug.com/289715 is resolved. Original issue's description: > CHECK that URLRequestJobs are not orphaned while blocked by extensions. > > This is to help debug https://crbug.com/289715 and try to get a stack trace > earlier. > > BUG=289715 > > Committed: https://crrev.com/a3ef438321e5f7f5167909b2b4b16dbd6593abb8 > Cr-Commit-Position: refs/heads/master@{#348745} TBR=mmenke@chromium.org,rdevlin.cronin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=289715 Committed: https://crrev.com/a2d5e73a547aeb417fe472d171940620ffb75c4f Cr-Commit-Position: refs/heads/master@{#360880}

Patch Set 1 #

Patch Set 2 : Make git do the revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -69 lines) Patch
M chrome/browser/net/chrome_extensions_network_delegate.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/chrome_extensions_network_delegate.cc View 1 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api.cc View 1 2 chunks +0 lines, -15 lines 0 comments Download
M net/base/layered_network_delegate.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/base/layered_network_delegate.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M net/base/network_delegate.h View 1 2 chunks +0 lines, -8 lines 0 comments Download
M net/base/network_delegate.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M net/base/network_delegate_impl.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M net/base/network_delegate_impl.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M net/url_request/url_request.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
davidben
Created Revert of CHECK that URLRequestJobs are not orphaned while blocked by extensions.
5 years, 1 month ago (2015-11-19 17:04:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465503002/1
5 years, 1 month ago (2015-11-19 17:04:53 UTC) #2
commit-bot: I haz the power
Failed to apply patch for chrome/browser/net/chrome_network_delegate.h: While running git apply --index -3 -p1; error: patch ...
5 years, 1 month ago (2015-11-19 17:05:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465503002/250001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465503002/250001
5 years, 1 month ago (2015-11-20 19:29:05 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:250001)
5 years, 1 month ago (2015-11-20 19:37:52 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 19:39:11 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a2d5e73a547aeb417fe472d171940620ffb75c4f
Cr-Commit-Position: refs/heads/master@{#360880}

Powered by Google App Engine
This is Rietveld 408576698