Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Side by Side Diff: net/base/network_delegate_impl.h

Issue 1465503002: Revert of CHECK that URLRequestJobs are not orphaned while blocked by extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make git do the revert Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/base/network_delegate.cc ('k') | net/base/network_delegate_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_BASE_NETWORK_DELEGATE_IMPL_H_ 5 #ifndef NET_BASE_NETWORK_DELEGATE_IMPL_H_
6 #define NET_BASE_NETWORK_DELEGATE_IMPL_H_ 6 #define NET_BASE_NETWORK_DELEGATE_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/strings/string16.h" 10 #include "base/strings/string16.h"
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 // Indicates that the URL request has been completed or failed. 140 // Indicates that the URL request has been completed or failed.
141 // |started| indicates whether the request has been started. If false, 141 // |started| indicates whether the request has been started. If false,
142 // some information like the socket address is not available. 142 // some information like the socket address is not available.
143 void OnCompleted(URLRequest* request, bool started) override; 143 void OnCompleted(URLRequest* request, bool started) override;
144 144
145 // Called when an URLRequest is being destroyed. Note that the request is 145 // Called when an URLRequest is being destroyed. Note that the request is
146 // being deleted, so it's not safe to call any methods that may result in 146 // being deleted, so it's not safe to call any methods that may result in
147 // a virtual method call. 147 // a virtual method call.
148 void OnURLRequestDestroyed(URLRequest* request) override; 148 void OnURLRequestDestroyed(URLRequest* request) override;
149 149
150 // Called when the current job for |request| is orphaned. This is a temporary
151 // callback to diagnose https://crbug.com/289715 and may not be used for other
152 // purposes. Note that it may be called after OnURLRequestDestroyed.
153 //
154 // TODO(davidben): Remove this once data has been gathered.
155 void OnURLRequestJobOrphaned(URLRequest* request) override;
156
157 // Corresponds to ProxyResolverJSBindings::OnError. 150 // Corresponds to ProxyResolverJSBindings::OnError.
158 void OnPACScriptError(int line_number, const base::string16& error) override; 151 void OnPACScriptError(int line_number, const base::string16& error) override;
159 152
160 // Called when a request receives an authentication challenge 153 // Called when a request receives an authentication challenge
161 // specified by |auth_info|, and is unable to respond using cached 154 // specified by |auth_info|, and is unable to respond using cached
162 // credentials. |callback| and |credentials| must be non-NULL, and must 155 // credentials. |callback| and |credentials| must be non-NULL, and must
163 // be valid until OnURLRequestDestroyed is called for |request|. 156 // be valid until OnURLRequestDestroyed is called for |request|.
164 // 157 //
165 // The following return values are allowed: 158 // The following return values are allowed:
166 // - AUTH_REQUIRED_RESPONSE_NO_ACTION: |auth_info| is observed, but 159 // - AUTH_REQUIRED_RESPONSE_NO_ACTION: |auth_info| is observed, but
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 // header is stripped from the request. 213 // header is stripped from the request.
221 bool OnCancelURLRequestWithPolicyViolatingReferrerHeader( 214 bool OnCancelURLRequestWithPolicyViolatingReferrerHeader(
222 const URLRequest& request, 215 const URLRequest& request,
223 const GURL& target_url, 216 const GURL& target_url,
224 const GURL& referrer_url) const override; 217 const GURL& referrer_url) const override;
225 }; 218 };
226 219
227 } // namespace net 220 } // namespace net
228 221
229 #endif // NET_BASE_NETWORK_DELEGATE_IMPL_H_ 222 #endif // NET_BASE_NETWORK_DELEGATE_IMPL_H_
OLDNEW
« no previous file with comments | « net/base/network_delegate.cc ('k') | net/base/network_delegate_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698