Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1465483002: Revert float xfermodes back to Sk4f (from Sk8f). (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert float xfermodes back to Sk4f (from Sk8f). Generally this was a performance win, even on devices without AVX due to unrolling, but on ARM+NEON it looks like that unrolling hurt a bit. while (...) { blend a pixel } ~~~> while (...) { blend two pixels } if (n % 2) { blend last pixel } BUG=chromium:555278 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/29d60e5ab594b39d1f533bff090877b1bb821e06

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -67 lines) Patch
M src/opts/SkXfermode_opts.h View 3 chunks +63 lines, -67 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465483002/1
5 years, 1 month ago (2015-11-19 16:54:48 UTC) #3
mtklein
lgtm
5 years, 1 month ago (2015-11-19 17:03:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465483002/1
5 years, 1 month ago (2015-11-19 17:03:38 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 17:10:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/29d60e5ab594b39d1f533bff090877b1bb821e06

Powered by Google App Engine
This is Rietveld 408576698