Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 1465443002: Modernize SkRecordPattern.h (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Modernize SkRecordPattern.h - Fold Or, Or3, Or4 into one flexible Or. - Fold Pattern1...Pattern7 into one flexible Pattern. - Rename Star Greedy Still fighting with a flexible get<N>() method instead of first, second, third, etc. BUG=skia: Committed: https://skia.googlesource.com/skia/+/24e7db8b2ea663f8fe4d7bbfa1d686fd643990bb

Patch Set 1 #

Patch Set 2 : short circuit #

Patch Set 3 : Fold Pattern1...Pattern7 into single flexible Pattern. #

Patch Set 4 : >> #

Patch Set 5 : rename star greedy #

Patch Set 6 : note #

Patch Set 7 : doc #

Patch Set 8 : inlines back #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -107 lines) Patch
M src/core/SkRecordOpts.cpp View 1 2 3 4 5 chunks +27 lines, -27 lines 0 comments Download
M src/core/SkRecordPattern.h View 1 2 3 4 5 6 7 3 chunks +39 lines, -70 lines 0 comments Download
M tests/RecordPatternTest.cpp View 1 2 3 4 4 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465443002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465443002/140001
5 years, 1 month ago (2015-11-19 16:18:31 UTC) #5
mtklein_C
5 years, 1 month ago (2015-11-19 16:29:08 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-19 16:30:03 UTC) #10
reed1
lgtm
5 years, 1 month ago (2015-11-19 16:49:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465443002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465443002/140001
5 years, 1 month ago (2015-11-19 16:52:37 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 16:53:40 UTC) #14
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/24e7db8b2ea663f8fe4d7bbfa1d686fd643990bb

Powered by Google App Engine
This is Rietveld 408576698