Fix a crasher in LoadFont() when non-standard font is used in XFA files

Fix a crasher in LoadFont() when non-standard font is used in XFA files

This CL includes the following changes:
1. Add return value for InitFont(). It can indicate a failure
   in the initialization of non-standard fonts.
2. Change NULL to nullptr.
3. Rewrite several pointer checking.

BUG=pdfium:279, pdfium:286
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/d6c62cfd71e5bc6b22e20f20384b748664e1aff4

[jun_fang, 2015-11-24 10:34:30]

Description was changed from

==========
Fix a crasher in LoadFont() when non-standard font is used in XFA files

BUG=pdfium:286
==========

to

==========
Fix a crasher in LoadFont() when non-standard font is used in XFA files

This CL includes the following changes:
1. Add return value for InitFont(). It can indicate a failure in the
initialization of non-standard fonts. 
2. Change NULL to nullptr.
3. Rewrite several pointer checking.

BUG=pdfium:286
==========

[jun_fang, 2015-11-24 10:34:31]

jun_fang@foxitsoftware.com changed reviewers:
+ kai_jing@foxitsoftware.com, thestig@chromium.org, tsepez@chromium.org

[jun_fang, 2015-11-24 10:34:54]

Description was changed from

==========
Fix a crasher in LoadFont() when non-standard font is used in XFA files

This CL includes the following changes:
1. Add return value for InitFont(). It can indicate a failure in the
initialization of non-standard fonts. 
2. Change NULL to nullptr.
3. Rewrite several pointer checking.

BUG=pdfium:286
==========

to

==========
Fix a crasher in LoadFont() when non-standard font is used in XFA files

This CL includes the following changes:
1. Add return value for InitFont(). It can indicate a failure 
   in the initialization of non-standard fonts. 
2. Change NULL to nullptr.
3. Rewrite several pointer checking.

BUG=pdfium:286
==========

[Tom Sepez, 2015-11-24 17:09:18]

lgtm

https://codereview.chromium.org/1465423002/diff/1/xfa/src/fgas/src/font/fx_ge...
File xfa/src/fgas/src/font/fx_gefont.cpp (right):

https://codereview.chromium.org/1465423002/diff/1/xfa/src/fgas/src/font/fx_ge...
xfa/src/fgas/src/font/fx_gefont.cpp:308: FX_BOOL bRet = (m_pFont = pExtFont) !=
nullptr;
nit: please do this assignment on its own line. Also, if you'd like, there's a
way to get a bool from a pointer via !! instead of the nullptr comparison, so
maybe:

m_pFont = pExtfont;
FX_BOOL bRet = !!m_pFont;

[jun_fang, 2015-11-25 06:49:38]

Description was changed from

==========
Fix a crasher in LoadFont() when non-standard font is used in XFA files

This CL includes the following changes:
1. Add return value for InitFont(). It can indicate a failure 
   in the initialization of non-standard fonts. 
2. Change NULL to nullptr.
3. Rewrite several pointer checking.

BUG=pdfium:286
==========

to

==========
Fix a crasher in LoadFont() when non-standard font is used in XFA files

This CL includes the following changes:
1. Add return value for InitFont(). It can indicate a failure 
   in the initialization of non-standard fonts. 
2. Change NULL to nullptr.
3. Rewrite several pointer checking.

BUG=pdfium:279, pdfium:286
==========

[jun_fang, 2015-11-25 06:49:58]

https://codereview.chromium.org/1465423002/diff/1/xfa/src/fgas/src/font/fx_ge...
File xfa/src/fgas/src/font/fx_gefont.cpp (right):

https://codereview.chromium.org/1465423002/diff/1/xfa/src/fgas/src/font/fx_ge...
xfa/src/fgas/src/font/fx_gefont.cpp:308: FX_BOOL bRet = (m_pFont = pExtFont) !=
nullptr;
On 2015/11/24 17:09:18, Tom Sepez wrote:
> nit: please do this assignment on its own line. Also, if you'd like, there's a
> way to get a bool from a pointer via !! instead of the nullptr comparison, so
> maybe:
> 
> m_pFont = pExtfont;
> FX_BOOL bRet = !!m_pFont;

Acknowledged.

[jun_fang, 2015-11-27 08:27:35]

Description was changed from

==========
Fix a crasher in LoadFont() when non-standard font is used in XFA files

This CL includes the following changes:
1. Add return value for InitFont(). It can indicate a failure 
   in the initialization of non-standard fonts. 
2. Change NULL to nullptr.
3. Rewrite several pointer checking.

BUG=pdfium:279, pdfium:286
==========

to

==========
Fix a crasher in LoadFont() when non-standard font is used in XFA files

This CL includes the following changes:
1. Add return value for InitFont(). It can indicate a failure
   in the initialization of non-standard fonts.
2. Change NULL to nullptr.
3. Rewrite several pointer checking.

BUG=pdfium:279, pdfium:286
R=tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/d6c62cfd71e5bc6b22e20f20384b748664e1...
==========

[jun_fang, 2015-11-27 08:27:41]

Committed patchset #2 (id:20001) manually as
d6c62cfd71e5bc6b22e20f20384b748664e1aff4 (presubmit successful).