xfa/src/fgas/src/font/fx_gefont.h - Issue 1465423002: Fix a crasher in LoadFont() when non-standard font is used in XFA files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fgas/src/font/fx_gefont.h

Issue 1465423002: Fix a crasher in LoadFont() when non-standard font is used in XFA files (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/src/fgas/src/font/fx_gefont.h

diff --git a/xfa/src/fgas/src/font/fx_gefont.h b/xfa/src/fgas/src/font/fx_gefont.h

index 5620f07bf29d3429bbeb595e63d155127d682596..a85cffa5e5a8c36e833af6adabc31ad2e307730f 100644

--- a/xfa/src/fgas/src/font/fx_gefont.h

+++ b/xfa/src/fgas/src/font/fx_gefont.h

@@ -72,7 +72,7 @@ class CFX_GEFont : public IFX_Font, public CFX_ThreadLock {

FX_WORD m_wCharSet;

CFX_PtrArray m_SubstFonts;

CFX_MapPtrToPtr m_FontMapper;

- void InitFont();

+ FX_BOOL InitFont();

FX_BOOL GetCharBBox(FX_WCHAR wUnicode,

CFX_Rect& bbox,

FX_BOOL bRecursive,

« no previous file with comments | « no previous file | xfa/src/fgas/src/font/fx_gefont.cpp » ('j') | no next file with comments »