[release] Add monitoring state to auto-roller json output.

tools/release/auto_roll.py

Index: tools/release/auto_roll.py
diff --git a/tools/release/auto_roll.py b/tools/release/auto_roll.py
index 16b80e840d501fcb85656be7f98f766cbe0fd0e3..a112df834f7bb7aadf5701ccab32c8dcc19f386e 100755
--- a/tools/release/auto_roll.py
+++ b/tools/release/auto_roll.py
@@ -24,6 +24,7 @@ class Preparation(Step):
   MESSAGE = "Preparation."
 
   def RunStep(self):
+    self['json_output']['monitoring_state'] = 'started'

[Michael Hablich, 2015/11/24 09:32:54]

It seems the state is reported when the script is winded down. This means that
'started' can only happen when there was an error. So, how about calling this
not 'started' but 'error'?

[Michael Achenbach, 2015/11/24 10:08:35]

That'd be the meaning behind started. I didn't wanted to call it error as I
still want to indicate that the actual script started. There would also be other
error states where it doesn't start. WDYT?

[Michael Hablich, 2015/11/24 10:30:55]

How about making it more verbose: Set 'monitoring_state' in each step. 'Started'
IMO leaves too much open for interpretation.

[Michael Achenbach, 2015/11/24 10:44:48]

OK. Done. Not sure if that verbosity helps, but it probably can't hurt (despite
more code).

     # Update v8 remote tracking branches.
     self.GitFetchOrigin()
     self.Git("fetch origin +refs/tags/*:refs/tags/*")
@@ -78,6 +79,7 @@ class DetectRevisionToRoll(Step):
     else:
       print("There is no newer v8 revision than the one in Chromium (%s)."
             % self["last_roll"])
+      self['json_output']['monitoring_state'] = 'up_to_date'

[Michael Hablich, 2015/11/24 09:32:54]

Why is this not a 'success'?

[Michael Achenbach, 2015/11/24 10:08:35]

Because I wan't to be able to monitor this case differently. If it claims it's
up-to-date for too long it might actually be a problem. I.e. it is stale...

[Michael Hablich, 2015/11/24 10:30:55]

See above comment. Interpretation of each exit state can than be done by the
monitor and not the script itself anymore. 

       return True
 
 
@@ -161,6 +163,7 @@ class CleanUp(Step):
   MESSAGE = "Done!"
 
   def RunStep(self):
+    self['json_output']['monitoring_state'] = 'success'
     print("Congratulations, you have successfully rolled %s into "
           "Chromium."
           % self["roll"])