[release] Add monitoring state to auto-roller json output.

tools/release/auto_roll.py

 #!/usr/bin/env python
 # Copyright 2014 the V8 project authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import argparse
 import os
 import sys
 
 from common_includes import *
 
 ROLL_SUMMARY = ("Summary of changes available at:\n"
                 "https://chromium.googlesource.com/v8/v8/+log/%s..%s")
 
 ISSUE_MSG = (
 """Please follow these instructions for assigning/CC'ing issues:
 https://code.google.com/p/v8-wiki/wiki/TriagingIssues
 
 Please close rolling in case of a roll revert:
 https://v8-roll.appspot.com/
 This only works with a Google account.""")
 
 class Preparation(Step):
   MESSAGE = "Preparation."
 
   def RunStep(self):
+    self['json_output']['monitoring_state'] = 'started'

[Michael Hablich, 2015/11/24 09:32:54]

It seems the state is reported when the script is winded down. This means that
'started' can only happen when there was an error. So, how about calling this
not 'started' but 'error'?

[Michael Achenbach, 2015/11/24 10:08:35]

That'd be the meaning behind started. I didn't wanted to call it error as I
still want to indicate that the actual script started. There would also be other
error states where it doesn't start. WDYT?

[Michael Hablich, 2015/11/24 10:30:55]

How about making it more verbose: Set 'monitoring_state' in each step. 'Started'
IMO leaves too much open for interpretation.

[Michael Achenbach, 2015/11/24 10:44:48]

OK. Done. Not sure if that verbosity helps, but it probably can't hurt (despite
more code).

     # Update v8 remote tracking branches.
     self.GitFetchOrigin()
     self.Git("fetch origin +refs/tags/*:refs/tags/*")
 
 
 class DetectLastRoll(Step):
   MESSAGE = "Detect commit ID of the last Chromium roll."
 
   def RunStep(self):
     self["last_roll"] = self._options.last_roll
@@ skipping 34 matching lines @@
     for revision in revisions:
       version = self.GetVersionTag(revision)
       assert version, "Internal error. All recent releases should have a tag"
 
       if SortingKey(self["last_version"]) < SortingKey(version):
         self["roll"] = revision
         break
     else:
       print("There is no newer v8 revision than the one in Chromium (%s)."
             % self["last_roll"])
+      self['json_output']['monitoring_state'] = 'up_to_date'

[Michael Hablich, 2015/11/24 09:32:54]

Why is this not a 'success'?

[Michael Achenbach, 2015/11/24 10:08:35]

Because I wan't to be able to monitor this case differently. If it claims it's
up-to-date for too long it might actually be a problem. I.e. it is stale...

[Michael Hablich, 2015/11/24 10:30:55]

See above comment. Interpretation of each exit state can than be done by the
monitor and not the script itself anymore. 

       return True
 
 
 class PrepareRollCandidate(Step):
   MESSAGE = "Robustness checks of the roll candidate."
 
   def RunStep(self):
     self["roll_title"] = self.GitLog(n=1, format="%s",
                                      git_hash=self["roll"])
 
@@ skipping 63 matching lines @@
     else:
       print "Dry run - don't upload."
 
     self.GitCheckout("master", cwd=cwd)
     self.GitDeleteBranch("work-branch", cwd=cwd)
 
 class CleanUp(Step):
   MESSAGE = "Done!"
 
   def RunStep(self):
+    self['json_output']['monitoring_state'] = 'success'
     print("Congratulations, you have successfully rolled %s into "
           "Chromium."
           % self["roll"])
 
     # Clean up all temporary files.
     Command("rm", "-f %s*" % self._config["PERSISTFILE_BASENAME"])
 
 
 class AutoRoll(ScriptsBase):
   def _PrepareOptions(self, parser):
@@ skipping 37 matching lines @@
       PrepareRollCandidate,
       SwitchChromium,
       UpdateChromiumCheckout,
       UploadCL,
       CleanUp,
     ]
 
 
 if __name__ == "__main__":  # pragma: no cover
   sys.exit(AutoRoll().Run())