[release] Add monitoring state to auto-roller json output.

[release] Add monitoring state to auto-roller json output.

The option --json-output will make the auto-roller dump a
json file with a monitoring_state key. This can be one of:
started, up_to_date, success.

BUG=chromium:559141
LOG=n
NOTRY=true

Committed: https://crrev.com/8cd3cf297287e581a49e487067f5cbd991b27123
Cr-Commit-Position: refs/heads/master@{#32201}

[Michael Achenbach, 2015-11-24 08:51:35]

Description was changed from

==========
[release] Add monitoring statue to auto-roller json output.

BUG=
==========

to

==========
[release] Add monitoring statue to auto-roller json output.

BUG=chromium:559141
LOG=n
NOTRY=true
==========

[Michael Achenbach, 2015-11-24 08:51:35]

machenbach@chromium.org changed reviewers:
+ hablich@chromium.org

[Michael Achenbach, 2015-11-24 09:18:09]

Description was changed from

==========
[release] Add monitoring statue to auto-roller json output.

BUG=chromium:559141
LOG=n
NOTRY=true
==========

to

==========
[release] Add monitoring statue to auto-roller json output.

The option --json-output will make the auto-roller dump a
json file with a monitoring_state key. This can be one of:
started, up_to_date, success.

BUG=chromium:559141
LOG=n
NOTRY=true
==========

[Michael Achenbach, 2015-11-24 09:18:30]

PTAL

[Michael Hablich, 2015-11-24 09:32:55]

It seems you want to report the step which created an error (or the success) if
something goes wrong, isn't it?

https://codereview.chromium.org/1465413002/diff/20001/tools/release/auto_roll.py
File tools/release/auto_roll.py (right):

https://codereview.chromium.org/1465413002/diff/20001/tools/release/auto_roll...
tools/release/auto_roll.py:27: self['json_output']['monitoring_state'] =
'started'
It seems the state is reported when the script is winded down. This means that
'started' can only happen when there was an error. So, how about calling this
not 'started' but 'error'?

https://codereview.chromium.org/1465413002/diff/20001/tools/release/auto_roll...
tools/release/auto_roll.py:82: self['json_output']['monitoring_state'] =
'up_to_date'
Why is this not a 'success'?

[Michael Achenbach, 2015-11-24 10:08:35]

https://codereview.chromium.org/1465413002/diff/20001/tools/release/auto_roll.py
File tools/release/auto_roll.py (right):

https://codereview.chromium.org/1465413002/diff/20001/tools/release/auto_roll...
tools/release/auto_roll.py:27: self['json_output']['monitoring_state'] =
'started'
On 2015/11/24 09:32:54, Hablich wrote:
> It seems the state is reported when the script is winded down. This means that
> 'started' can only happen when there was an error. So, how about calling this
> not 'started' but 'error'?

That'd be the meaning behind started. I didn't wanted to call it error as I
still want to indicate that the actual script started. There would also be other
error states where it doesn't start. WDYT?

https://codereview.chromium.org/1465413002/diff/20001/tools/release/auto_roll...
tools/release/auto_roll.py:82: self['json_output']['monitoring_state'] =
'up_to_date'
On 2015/11/24 09:32:54, Hablich wrote:
> Why is this not a 'success'?

Because I wan't to be able to monitor this case differently. If it claims it's
up-to-date for too long it might actually be a problem. I.e. it is stale...

[Michael Achenbach, 2015-11-24 10:14:38]

Description was changed from

==========
[release] Add monitoring statue to auto-roller json output.

The option --json-output will make the auto-roller dump a
json file with a monitoring_state key. This can be one of:
started, up_to_date, success.

BUG=chromium:559141
LOG=n
NOTRY=true
==========

to

==========
[release] Add monitoring state to auto-roller json output.

The option --json-output will make the auto-roller dump a
json file with a monitoring_state key. This can be one of:
started, up_to_date, success.

BUG=chromium:559141
LOG=n
NOTRY=true
==========

[Michael Hablich, 2015-11-24 10:30:55]

https://codereview.chromium.org/1465413002/diff/20001/tools/release/auto_roll.py
File tools/release/auto_roll.py (right):

https://codereview.chromium.org/1465413002/diff/20001/tools/release/auto_roll...
tools/release/auto_roll.py:27: self['json_output']['monitoring_state'] =
'started'
On 2015/11/24 10:08:35, Michael Achenbach wrote:
> On 2015/11/24 09:32:54, Hablich wrote:
> > It seems the state is reported when the script is winded down. This means
that
> > 'started' can only happen when there was an error. So, how about calling
this
> > not 'started' but 'error'?
> 
> That'd be the meaning behind started. I didn't wanted to call it error as I
> still want to indicate that the actual script started. There would also be
other
> error states where it doesn't start. WDYT?

How about making it more verbose: Set 'monitoring_state' in each step. 'Started'
IMO leaves too much open for interpretation.

https://codereview.chromium.org/1465413002/diff/20001/tools/release/auto_roll...
tools/release/auto_roll.py:82: self['json_output']['monitoring_state'] =
'up_to_date'
On 2015/11/24 10:08:35, Michael Achenbach wrote:
> On 2015/11/24 09:32:54, Hablich wrote:
> > Why is this not a 'success'?
> 
> Because I wan't to be able to monitor this case differently. If it claims it's
> up-to-date for too long it might actually be a problem. I.e. it is stale...

See above comment. Interpretation of each exit state can than be done by the
monitor and not the script itself anymore.

[Michael Achenbach, 2015-11-24 10:44:48]

PTAL

https://codereview.chromium.org/1465413002/diff/20001/tools/release/auto_roll.py
File tools/release/auto_roll.py (right):

https://codereview.chromium.org/1465413002/diff/20001/tools/release/auto_roll...
tools/release/auto_roll.py:27: self['json_output']['monitoring_state'] =
'started'
On 2015/11/24 10:30:55, Hablich wrote:
> On 2015/11/24 10:08:35, Michael Achenbach wrote:
> > On 2015/11/24 09:32:54, Hablich wrote:
> > > It seems the state is reported when the script is winded down. This means
> that
> > > 'started' can only happen when there was an error. So, how about calling
> this
> > > not 'started' but 'error'?
> > 
> > That'd be the meaning behind started. I didn't wanted to call it error as I
> > still want to indicate that the actual script started. There would also be
> other
> > error states where it doesn't start. WDYT?
> 
> How about making it more verbose: Set 'monitoring_state' in each step.
'Started'
> IMO leaves too much open for interpretation.

OK. Done. Not sure if that verbosity helps, but it probably can't hurt (despite
more code).

[Michael Hablich, 2015-11-24 10:50:00]

On 2015/11/24 10:44:48, Michael Achenbach wrote:
> PTAL
> 
>
https://codereview.chromium.org/1465413002/diff/20001/tools/release/auto_roll.py
> File tools/release/auto_roll.py (right):
> 
>
https://codereview.chromium.org/1465413002/diff/20001/tools/release/auto_roll...
> tools/release/auto_roll.py:27: self['json_output']['monitoring_state'] =
> 'started'
> On 2015/11/24 10:30:55, Hablich wrote:
> > On 2015/11/24 10:08:35, Michael Achenbach wrote:
> > > On 2015/11/24 09:32:54, Hablich wrote:
> > > > It seems the state is reported when the script is winded down. This
means
> > that
> > > > 'started' can only happen when there was an error. So, how about calling
> > this
> > > > not 'started' but 'error'?
> > > 
> > > That'd be the meaning behind started. I didn't wanted to call it error as
I
> > > still want to indicate that the actual script started. There would also be
> > other
> > > error states where it doesn't start. WDYT?
> > 
> > How about making it more verbose: Set 'monitoring_state' in each step.
> 'Started'
> > IMO leaves too much open for interpretation.
> 
> OK. Done. Not sure if that verbosity helps, but it probably can't hurt
(despite
> more code).

lgtm

[Michael Achenbach, 2015-11-24 10:51:05]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2015-11-24 10:51:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1465413002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1465413002/40001

[commit-bot: I haz the power, 2015-11-24 11:00:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-24 11:00:25]

Patchset 3 (id:??) landed as
https://crrev.com/8cd3cf297287e581a49e487067f5cbd991b27123
Cr-Commit-Position: refs/heads/master@{#32201}