Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: chrome/android/java/res/layout/storage_preference_fragment.xml

Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments, splitting off dialog logic, etc Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/storage_preference_fragment.xml
diff --git a/chrome/android/java/res/layout/storage_preference_fragment.xml b/chrome/android/java/res/layout/storage_preference_fragment.xml
new file mode 100644
index 0000000000000000000000000000000000000000..ba8b65692d09914ac9072d9f39beb7492b79e83b
--- /dev/null
+++ b/chrome/android/java/res/layout/storage_preference_fragment.xml
@@ -0,0 +1,56 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2015 The Chromium Authors. All rights reserved.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file. -->
+
+<!-- Based on Android framework file, with customization to keep button bar
+ visible when the list view is empty:
+ platform_frameworks_base/core/res/res/layout/preference_list_fragment.xml
+ -->
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+ android:orientation="vertical"
+ android:layout_height="match_parent"
+ android:layout_width="match_parent"
+ android:background="@android:color/transparent">
+
+ <FrameLayout
+ android:layout_width="match_parent"
+ android:layout_height="0dp"
+ android:layout_weight="1"
+ android:background="@android:color/transparent">
+
+ <ListView android:id="@android:id/list"
+ android:layout_width="match_parent"
+ android:layout_height="match_parent"
+ android:paddingTop="0dip"
+ android:paddingBottom="0dp"
+ android:clipToPadding="false"
+ android:drawSelectorOnTop="false"
+ android:cacheColorHint="@android:color/transparent"
+ android:scrollbarAlwaysDrawVerticalTrack="true" />
+
+ <TextView android:id="@android:id/empty"
+ android:layout_width="match_parent"
+ android:layout_height="match_parent"
+ android:padding="8dip"
+ android:textAppearance="?android:attr/textAppearanceMedium"
+ android:gravity="center"
+ android:visibility="gone" />
+
Finnur 2015/11/26 15:54:41 nit: Remove line break.
dmurph 2015/11/30 22:16:52 Done.
+ </FrameLayout>
Finnur 2015/11/26 15:54:41 Indentation seems off.
dmurph 2015/11/30 22:16:52 Done.
+
+ <RelativeLayout android:id="@+id/button_bar"
+ android:layout_height="wrap_content"
+ android:layout_width="match_parent"
+ android:layout_weight="0">
+
+ <Button android:id="@+id/clear_button"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:layout_margin="5dip"
+ android:layout_weight="1"
+ android:text="@string/storage_clear_button_title"/>
+
Finnur 2015/11/26 15:54:41 nit: Remove line break.
dmurph 2015/11/30 22:16:52 On 2015/11/26 at 15:54:41, Finnur wrote: > nit: Re
+ </RelativeLayout>
+
+</LinearLayout>

Powered by Google App Engine
This is Rietveld 408576698