chrome/android/java/res/layout/storage_preference_fragment.xml - Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/storage_preference_fragment.xml

Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments, splitting off dialog logic, etc Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/AndroidManifest.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ClearAllStorageAction.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ClearAllStorageAction.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <!-- Based on Android framework file, with customization to keep button bar

	7 visible when the list view is empty:

	8 platform_frameworks_base/core/res/res/layout/preference_list_fragment.xml

	9 -->

	10 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

	11 android:orientation="vertical"

	12 android:layout_height="match_parent"

	13 android:layout_width="match_parent"

	14 android:background="@android:color/transparent">

	15

	16 <FrameLayout

	17 android:layout_width="match_parent"

	18 android:layout_height="0dp"

	19 android:layout_weight="1"

	20 android:background="@android:color/transparent">

	21

	22 <ListView android:id="@android:id/list"

	23 android:layout_width="match_parent"

	24 android:layout_height="match_parent"

	25 android:paddingTop="0dip"

	26 android:paddingBottom="0dp"

	27 android:clipToPadding="false"

	28 android:drawSelectorOnTop="false"

	29 android:cacheColorHint="@android:color/transparent"

	30 android:scrollbarAlwaysDrawVerticalTrack="true" />

	31

	32 <TextView android:id="@android:id/empty"

	33 android:layout_width="match_parent"

	34 android:layout_height="match_parent"

	35 android:padding="8dip"

	36 android:textAppearance="?android:attr/textAppearanceMedium"

	37 android:gravity="center"

	38 android:visibility="gone" />

	39
	Finnur 2015/11/26 15:54:41 nit: Remove line break. nit: Remove line break. dmurph 2015/11/30 22:16:52 Done. Show quoted text On 2015/11/26 at 15:54:41, Finnur wrote: > nit: Remove line break. Done.
	40 </FrameLayout>
	Finnur 2015/11/26 15:54:41 Indentation seems off. Indentation seems off. dmurph 2015/11/30 22:16:52 Done. Show quoted text On 2015/11/26 at 15:54:41, Finnur wrote: > Indentation seems off. Done.
	41

	42 <RelativeLayout android:id="@+id/button_bar"

	43 android:layout_height="wrap_content"

	44 android:layout_width="match_parent"

	45 android:layout_weight="0">

	46

	47 <Button android:id="@+id/clear_button"

	48 android:layout_width="match_parent"

	49 android:layout_height="wrap_content"

	50 android:layout_margin="5dip"

	51 android:layout_weight="1"

	52 android:text="@string/storage_clear_button_title"/>

	53
	Finnur 2015/11/26 15:54:41 nit: Remove line break. nit: Remove line break. dmurph 2015/11/30 22:16:52 On 2015/11/26 at 15:54:41, Finnur wrote: > nit: Re Show quoted text On 2015/11/26 at 15:54:41, Finnur wrote: > nit: Remove line break.
	54 </RelativeLayout>

	55

	56 </LinearLayout>

OLD	NEW