[Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog

chrome/android/java/res/layout/storage_preference_fragment.xml

Index: chrome/android/java/res/layout/storage_preference_fragment.xml
diff --git a/chrome/android/java/res/layout/storage_preference_fragment.xml b/chrome/android/java/res/layout/storage_preference_fragment.xml
new file mode 100644
index 0000000000000000000000000000000000000000..209b95d87c559da06cb5c0a388d4afcc7c3bf41c
--- /dev/null
+++ b/chrome/android/java/res/layout/storage_preference_fragment.xml
@@ -0,0 +1,35 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2016 The Chromium Authors. All rights reserved.
+     Use of this source code is governed by a BSD-style license that can be
+     found in the LICENSE file. -->
+
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    android:orientation="vertical"
+    android:layout_height="match_parent"
+    android:layout_width="match_parent"
+    android:background="@android:color/transparent">
+
+    <ListView android:id="@android:id/list"
+        android:layout_width="match_parent"
+        android:layout_height="0px"
+        android:layout_weight="1"
+        android:paddingTop="0dp"
+        android:paddingBottom="0dp"
+        android:clipToPadding="false"

[Ted C, 2016/05/16 23:32:07]

the padding is 0, why do we need this?

[dmurph, 2016/05/18 23:27:59]

Dunno, copied this file.

+        android:cacheColorHint="@android:color/transparent"/>

[Ted C, 2016/05/16 23:32:07]

what is this accomplishing?

in particular, it states that it will be used to help android since it is
drawing on top of a solid opaque color, which transparent isn't.

https://developer.android.com/reference/android/widget/AbsListView.html#attr_...

[dmurph, 2016/05/18 23:27:59]

Dunno, I copied this from the default style.

+
+    <TextView android:id="@android:id/empty"
+        android:layout_width="match_parent"
+        android:layout_height="match_parent"
+        android:padding="8dp"
+        android:textAppearance="?android:attr/textAppearanceMedium"
+        android:gravity="center"
+        android:visibility="gone"/>
+
+    <Button android:id="@+id/clear_button"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:layout_weight="0"

[Ted C, 2016/05/16 23:32:07]

I think we typically don't specify 0 as it is the default value.  Not
technically wrong though I guess.

[dmurph, 2016/05/18 23:27:59]

Done.

+        android:text="@string/storage_clear_button_title"
+        style="?android:attr/borderlessButtonStyle"/>
+</LinearLayout>