chrome/android/java/res/layout/storage_preference_fragment.xml - Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/storage_preference_fragment.xml

Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed frame layout Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/layout/select_dialog_listview.xml ('K') | « chrome/android/java/res/layout/select_dialog_listview.xml ('k') | chrome/android/java/res/values-v17/styles.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

	7 android:orientation="vertical"

	8 android:layout_height="match_parent"

	9 android:layout_width="match_parent"

	10 android:background="@android:color/transparent">

	11

	12 <ListView android:id="@android:id/list"

	13 android:layout_width="match_parent"

	14 android:layout_height="0px"

	15 android:layout_weight="1"

	16 android:paddingTop="0dp"

	17 android:paddingBottom="0dp"

	18 android:clipToPadding="false"
	Ted C 2016/05/16 23:32:07 the padding is 0, why do we need this? the padding is 0, why do we need this? dmurph 2016/05/18 23:27:59 Dunno, copied this file. Show quoted text On 2016/05/16 at 23:32:07, Ted C wrote: > the padding is 0, why do we need this? Dunno, copied this file.
	19 android:cacheColorHint="@android:color/transparent"/>
	Ted C 2016/05/16 23:32:07 what is this accomplishing? in particular, it sta what is this accomplishing? in particular, it states that it will be used to help android since it is drawing on top of a solid opaque color, which transparent isn't. https://developer.android.com/reference/android/widget/AbsListView.html#attr_... dmurph 2016/05/18 23:27:59 Dunno, I copied this from the default style. Show quoted text On 2016/05/16 at 23:32:07, Ted C wrote: > what is this accomplishing? > > in particular, it states that it will be used to help android since it is drawing on top of a solid opaque color, which transparent isn't. > > https://developer.android.com/reference/android/widget/AbsListView.html#attr_... Dunno, I copied this from the default style.
	20

	21 <TextView android:id="@android:id/empty"

	22 android:layout_width="match_parent"

	23 android:layout_height="match_parent"

	24 android:padding="8dp"

	25 android:textAppearance="?android:attr/textAppearanceMedium"

	26 android:gravity="center"

	27 android:visibility="gone"/>

	28

	29 <Button android:id="@+id/clear_button"

	30 android:layout_width="match_parent"

	31 android:layout_height="wrap_content"

	32 android:layout_weight="0"
	Ted C 2016/05/16 23:32:07 I think we typically don't specify 0 as it is the I think we typically don't specify 0 as it is the default value. Not technically wrong though I guess. dmurph 2016/05/18 23:27:59 Done. Show quoted text On 2016/05/16 at 23:32:07, Ted C wrote: > I think we typically don't specify 0 as it is the default value. Not technically wrong though I guess. Done.
	33 android:text="@string/storage_clear_button_title"

	34 style="?android:attr/borderlessButtonStyle"/>

	35 </LinearLayout>

OLD	NEW