[Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog

chrome/android/java/res/layout/storage_preference_fragment.xml

Index: chrome/android/java/res/layout/storage_preference_fragment.xml
diff --git a/chrome/android/java/res/layout/storage_preference_fragment.xml b/chrome/android/java/res/layout/storage_preference_fragment.xml
new file mode 100644
index 0000000000000000000000000000000000000000..558199348c418f36f6294fbbf919d87f942388c1
--- /dev/null
+++ b/chrome/android/java/res/layout/storage_preference_fragment.xml
@@ -0,0 +1,47 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2016 The Chromium Authors. All rights reserved.
+     Use of this source code is governed by a BSD-style license that can be
+     found in the LICENSE file. -->
+
+<!-- Based on Android framework file here:
+     platform_frameworks_base/core/res/res/layout/preference_list_fragment.xml

[Theresa, 2016/04/27 21:10:58]

This path doesn't exist in our code base. I would drop this line as well.

[dmurph, 2016/04/29 23:53:47]

Done.

+     -->
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    android:orientation="vertical"
+    android:layout_height="match_parent"
+    android:layout_width="match_parent"
+    android:background="@android:color/transparent">
+
+    <ListView android:id="@android:id/list"
+        android:layout_width="match_parent"
+        android:layout_height="0px"
+        android:layout_weight="1"
+        android:paddingTop="0dip"

[Theresa, 2016/04/27 21:10:57]

replace dip with dp (here and below)

[dmurph, 2016/04/29 23:53:48]

Done.

+        android:paddingBottom="0dp"
+        android:clipToPadding="false"
+        android:drawSelectorOnTop="false"

[Theresa, 2016/04/27 21:10:57]

This defaults to false.

[dmurph, 2016/04/29 23:53:47]

Done.

+        android:cacheColorHint="@android:color/transparent"
+        android:scrollbarAlwaysDrawVerticalTrack="true" />

[Theresa, 2016/04/27 21:10:58]

Does this need to be set to true? If there's no vertical scroll, it seems odd to
show the track anyway.

[dmurph, 2016/04/29 23:53:47]

I don't know. Seems to still work. This file was copied.

+
+    <TextView android:id="@android:id/empty"
+        android:layout_width="match_parent"
+        android:layout_height="match_parent"
+        android:padding="8dip"
+        android:textAppearance="?android:attr/textAppearanceMedium"
+        android:gravity="center"
+        android:visibility="gone"
+    />

[Theresa, 2016/04/27 21:10:58]

Put this on the line above

[dmurph, 2016/04/29 23:53:47]

Done.

+
+    <RelativeLayout android:id="@+id/button_bar"
+        android:layout_height="wrap_content"
+        android:layout_width="match_parent"
+        android:layout_weight="0">
+
+        <Button android:id="@+id/clear_button"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:layout_margin="5dip"
+            android:text="@string/storage_clear_button_title"
+        />

[Theresa, 2016/04/27 21:10:57]

Put this on the line above.

[dmurph, 2016/04/29 23:53:47]

Done.

+    </RelativeLayout>
+</LinearLayout>