[Android] Add context manager to record logcat during step(s).

[Android] Add context manager to record logcat during step(s).

BUG=552069
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297933

[mikecase (-- gone --), 2015-11-23 22:02:28]

mikecase@chromium.org changed reviewers:
+ jbudorick@chromium.org, luqui@chromium.org

[mikecase (-- gone --), 2015-11-23 22:02:29]

Want to add per-step logcat to help debugging tests easier. Most of the changes
are in chromium_android/api.py (added new logcat() context manager). PTAL.

[mikecase (-- gone --), 2015-11-23 22:31:13]

mikecase@chromium.org changed reviewers:
+ martiniss@chromium.org

[luqui, 2015-11-23 22:59:40]

This is a great improvement.  Though it doesn't seem to be used at all public
side, I'd like to see an example of it in action.

https://codereview.chromium.org/1465343002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_android/api.py (right):

https://codereview.chromium.org/1465343002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/api.py:671: logcat_dir =
self.m.chromium.c.build_dir.join('logcat')
Sure you don't want this to be a config item?

https://codereview.chromium.org/1465343002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/api.py:722:
self.logcat_dump(logcat_dir=logcat_dir,
Will this kill the logcat monitor..  or will the next spawn_logcat_monitor
reset, or... Just wondering what the flow is like when there are multiple of
these.

https://codereview.chromium.org/1465343002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_android/example.py (right):

https://codereview.chromium.org/1465343002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/example.py:186:
api.chromium_android.logcat_dump(output_logcat_file=logcat_file)
Heck as long as you're here you might as well use the context manager, right?

[mikecase (-- gone --), 2015-11-24 20:50:59]

https://codereview.chromium.org/1465343002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_android/api.py (right):

https://codereview.chromium.org/1465343002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/api.py:671: logcat_dir =
self.m.chromium.c.build_dir.join('logcat')
On 2015/11/23 at 22:59:40, luqui wrote:
> Sure you don't want this to be a config item?

Added default_logcat_dir to config.

https://codereview.chromium.org/1465343002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/api.py:722:
self.logcat_dump(logcat_dir=logcat_dir,
On 2015/11/23 at 22:59:40, luqui wrote:
> Will this kill the logcat monitor..  or will the next spawn_logcat_monitor
reset, or... Just wondering what the flow is like when there are multiple of
these.

So, I looked through the scripts, spawn_logcat_monitor will start a process that
records the logcats from all devices into a directory. It also stores its
process ID in a specially named file in the directory. When you call logcat_dump
on that same directory, it kills the process with the PID from the specially
named file. So yeah, logcat_dump will kill the associated logcat_monitor for a
given directory.

https://codereview.chromium.org/1465343002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_android/example.py (right):

https://codereview.chromium.org/1465343002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/example.py:186:
api.chromium_android.logcat_dump(output_logcat_file=logcat_file)
On 2015/11/23 at 22:59:40, luqui wrote:
> Heck as long as you're here you might as well use the context manager, right?

Added an example of using the logcat context manager above for the test runs.

[luqui, 2015-11-24 21:26:04]

A bit hard to see through all the rebasing, lgtm anyhow.  I suggest another pair
of eyes.

[jbudorick, 2015-11-30 19:30:43]

https://codereview.chromium.org/1465343002/diff/60001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_android/api.py (right):

https://codereview.chromium.org/1465343002/diff/60001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/api.py:803:
self.spawn_logcat_monitor()
I'm not sure that we want this one any more.

[mikecase (-- gone --), 2015-12-03 01:07:10]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2015-12-03 01:07:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1465343002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1465343002/60001

[commit-bot: I haz the power, 2015-12-03 01:13:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-03 01:14:01]

Try jobs failed on following builders:
  Build Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[mikecase (-- gone --), 2015-12-03 17:56:20]

mikecase@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[mikecase (-- gone --), 2015-12-03 17:56:21]

Forgot to add owner of chromium_tests,
+phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2015-12-04 10:47:14]

LGTM

[mikecase (-- gone --), 2015-12-09 01:00:04]

The CQ bit was checked by mikecase@chromium.org

[mikecase (-- gone --), 2015-12-09 01:00:05]

The patchset sent to the CQ was uploaded after l-g-t-m from luqui@chromium.org
Link to the patchset: https://codereview.chromium.org/1465343002/#ps70001
(title: "Rebase")

[commit-bot: I haz the power, 2015-12-09 01:00:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1465343002/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1465343002/70001

[commit-bot: I haz the power, 2015-12-09 01:13:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 01:13:43]

Try jobs failed on following builders:
  Build Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[chromium-reviews, 2015-12-09 01:19:15]

You need to train your expectations. Legit failure

On Tue, Dec 8, 2015, 5:13 PM commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Try jobs failed on following builders:
>    Build Presubmit on tryserver.infra (JOB_FAILED,
>
>
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...
> )
>
> https://codereview.chromium.org/1465343002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[mikecase (-- gone --), 2015-12-10 01:41:53]

The CQ bit was checked by mikecase@chromium.org

[mikecase (-- gone --), 2015-12-10 01:41:54]

The patchset sent to the CQ was uploaded after l-g-t-m from luqui@chromium.org,
phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/1465343002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2015-12-10 01:42:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1465343002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1465343002/80001

[commit-bot: I haz the power, 2015-12-10 01:46:24]

Description was changed from

==========
[Android] Add context manager to record logcat during step(s).

BUG=552069
==========

to

==========
[Android] Add context manager to record logcat during step(s).

BUG=552069

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297933
==========

[commit-bot: I haz the power, 2015-12-10 01:46:25]

Committed patchset #7 (id:80001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297933