Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipes/android_webview_shell_tests.py

Issue 1465343002: [Android] Add context manager to record logcat during step(s). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipes/android_webview_cts_tests.expected/Test_parsing_report_xml_with_unexpected_method_failed.json ('k') | scripts/slave/recipes/android_webview_shell_tests.expected/basic.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/android_webview_shell_tests.py
diff --git a/scripts/slave/recipes/android_webview_shell_tests.py b/scripts/slave/recipes/android_webview_shell_tests.py
index 8d869ed59f239b791c6a8b8bab654bb55bffcc1a..98f8baaa9b8d071063cff35d407b0af77a0aaef8 100644
--- a/scripts/slave/recipes/android_webview_shell_tests.py
+++ b/scripts/slave/recipes/android_webview_shell_tests.py
@@ -88,9 +88,8 @@ def RunSteps(api):
for suite in INSTRUMENTATION_TESTS:
run_instrumentation_test(api, suite)
- logcat_file = api.chromium.output_dir.join('full_logcat')
- api.chromium_android.logcat_dump(output_logcat_file=logcat_file)
- api.chromium_android.stack_tool_steps(logcat_file=logcat_file)
+ api.chromium_android.logcat_dump()
+ api.chromium_android.stack_tool_steps()
api.chromium_android.test_report()
def run_instrumentation_test(api, suite):
« no previous file with comments | « scripts/slave/recipes/android_webview_cts_tests.expected/Test_parsing_report_xml_with_unexpected_method_failed.json ('k') | scripts/slave/recipes/android_webview_shell_tests.expected/basic.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698