Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1103)

Issue 1465333002: Merge to XFA: Enable Dr. Memory to run javascript, pixel, and corpus tests (Closed)

Created:
5 years, 1 month ago by zhaoqin1
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Enable Dr. Memory to run javascript, pixel, and corpus tests - add DrMemoryWrapper in common.py to adjust Dr. Memory wrapper - add --wrapper option to run_*_tests.py for Dr. Mempry wrapper - update run_*_tests.py to handle Dr. Memory wrapper - add TestPDFiumTest in pdfium_tests.py to support run_*_tests.py - remove ValgrindTool in valgrind_tests.py R=thestig@chromium.org BUG=pdfium:238 Review URL: https://codereview.chromium.org/1464453003 . (cherry picked from commit 36476923ae5eb8e9283e605f3c85ee8811c86014) Committed: https://pdfium.googlesource.com/pdfium/+/fba46da798abae8c8cc0e9329e14bca860c2afc6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -310 lines) Patch
M testing/tools/common.py View 2 chunks +33 lines, -0 lines 0 comments Download
M testing/tools/run_corpus_tests.py View 5 chunks +14 lines, -6 lines 0 comments Download
M testing/tools/run_javascript_tests.py View 4 chunks +11 lines, -3 lines 0 comments Download
M testing/tools/run_pixel_tests.py View 4 chunks +11 lines, -3 lines 0 comments Download
M tools/drmemory/scripts/pdfium_tests.py View 2 chunks +48 lines, -6 lines 0 comments Download
M tools/drmemory/scripts/valgrind_test.py View 4 chunks +9 lines, -292 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
zhaoqin1
Committed patchset #1 (id:1) manually as fba46da798abae8c8cc0e9329e14bca860c2afc6 (presubmit successful).
5 years, 1 month ago (2015-11-23 21:50:54 UTC) #1
Lei Zhang
5 years, 1 month ago (2015-11-23 22:19:19 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698