Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1464453003: Enable Dr. Memory to run javascript, pixel, and corpus tests (Closed)

Created:
5 years, 1 month ago by zhaoqin1
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang, zhaoqin
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enable Dr. Memory to run javascript, pixel, and corpus tests - add DrMemoryWrapper in common.py to adjust Dr. Memory wrapper - add --wrapper option to run_*_tests.py for Dr. Mempry wrapper - update run_*_tests.py to handle Dr. Memory wrapper - add TestPDFiumTest in pdfium_tests.py to support run_*_tests.py - remove ValgrindTool in valgrind_tests.py R=thestig@chromium.org BUG=pdfium:238 Committed: https://pdfium.googlesource.com/pdfium/+/36476923ae5eb8e9283e605f3c85ee8811c86014

Patch Set 1 #

Total comments: 30

Patch Set 2 : PTAL #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -311 lines) Patch
M testing/tools/common.py View 1 2 chunks +33 lines, -0 lines 0 comments Download
M testing/tools/run_corpus_tests.py View 1 5 chunks +13 lines, -6 lines 2 comments Download
M testing/tools/run_javascript_tests.py View 1 4 chunks +11 lines, -3 lines 0 comments Download
M testing/tools/run_pixel_tests.py View 1 4 chunks +11 lines, -3 lines 0 comments Download
M tools/drmemory/scripts/pdfium_tests.py View 1 2 chunks +49 lines, -7 lines 2 comments Download
M tools/drmemory/scripts/valgrind_test.py View 1 4 chunks +9 lines, -292 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
zhaoqin1
5 years, 1 month ago (2015-11-19 22:35:22 UTC) #1
Lei Zhang
Looking. I fixed the typo in the CL description. FWIW, locally I've been just running ...
5 years, 1 month ago (2015-11-19 22:38:32 UTC) #3
zhaoqin
On 2015/11/19 22:38:32, Lei Zhang wrote: > Looking. I fixed the typo in the CL ...
5 years, 1 month ago (2015-11-19 22:44:04 UTC) #4
Lei Zhang
https://codereview.chromium.org/1464453003/diff/1/testing/tools/common.py File testing/tools/common.py (right): https://codereview.chromium.org/1464453003/diff/1/testing/tools/common.py#newcode9 testing/tools/common.py:9: import glob alphabetical order https://codereview.chromium.org/1464453003/diff/1/testing/tools/common.py#newcode33 testing/tools/common.py:33: def DrMemoryWrapper(wrapper, pdf_name): ...
5 years, 1 month ago (2015-11-20 00:17:48 UTC) #5
zhaoqin1
PTAL https://codereview.chromium.org/1464453003/diff/1/testing/tools/common.py File testing/tools/common.py (right): https://codereview.chromium.org/1464453003/diff/1/testing/tools/common.py#newcode9 testing/tools/common.py:9: import glob On 2015/11/20 00:17:47, Lei Zhang wrote: ...
5 years, 1 month ago (2015-11-21 04:20:46 UTC) #6
Lei Zhang
lgtm https://codereview.chromium.org/1464453003/diff/20001/testing/tools/run_corpus_tests.py File testing/tools/run_corpus_tests.py (right): https://codereview.chromium.org/1464453003/diff/20001/testing/tools/run_corpus_tests.py#newcode44 testing/tools/run_corpus_tests.py:44: cmd_to_run = common.DrMemoryWrapper(drmem_wrapper, input_filename[:-4]) Use os.path.splitext(input_filename) https://codereview.chromium.org/1464453003/diff/20001/tools/drmemory/scripts/pdfium_tests.py File ...
5 years, 1 month ago (2015-11-21 20:21:59 UTC) #7
zhaoqin1
Committed patchset #2 (id:20001) manually as 36476923ae5eb8e9283e605f3c85ee8811c86014 (presubmit successful).
5 years, 1 month ago (2015-11-23 21:45:54 UTC) #8
zhaoqin
https://codereview.chromium.org/1464453003/diff/20001/testing/tools/run_corpus_tests.py File testing/tools/run_corpus_tests.py (right): https://codereview.chromium.org/1464453003/diff/20001/testing/tools/run_corpus_tests.py#newcode44 testing/tools/run_corpus_tests.py:44: cmd_to_run = common.DrMemoryWrapper(drmem_wrapper, input_filename[:-4]) On 2015/11/21 20:21:59, Lei Zhang ...
5 years, 1 month ago (2015-11-23 21:47:19 UTC) #10
Lei Zhang
On 2015/11/23 21:47:19, zhaoqin wrote: > https://codereview.chromium.org/1464453003/diff/20001/testing/tools/run_corpus_tests.py > File testing/tools/run_corpus_tests.py (right): > > https://codereview.chromium.org/1464453003/diff/20001/testing/tools/run_corpus_tests.py#newcode44 > ...
5 years, 1 month ago (2015-11-23 22:19:16 UTC) #11
zhaoqin
5 years, 1 month ago (2015-11-23 22:26:53 UTC) #12
Message was sent while issue was closed.
On 2015/11/23 22:19:16, Lei Zhang wrote:
> On 2015/11/23 21:47:19, zhaoqin wrote:
> >
>
https://codereview.chromium.org/1464453003/diff/20001/testing/tools/run_corpu...
> > File testing/tools/run_corpus_tests.py (right):
> > 
> >
>
https://codereview.chromium.org/1464453003/diff/20001/testing/tools/run_corpu...
> > testing/tools/run_corpus_tests.py:44: cmd_to_run =
> > common.DrMemoryWrapper(drmem_wrapper, input_filename[:-4])
> > On 2015/11/21 20:21:59, Lei Zhang wrote:
> > > Use os.path.splitext(input_filename)
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/1464453003/diff/20001/tools/drmemory/scripts/...
> > File tools/drmemory/scripts/pdfium_tests.py (right):
> > 
> >
>
https://codereview.chromium.org/1464453003/diff/20001/tools/drmemory/scripts/...
> > tools/drmemory/scripts/pdfium_tests.py:319: }
> > On 2015/11/21 20:21:59, Lei Zhang wrote:
> > > 2 spaces too many indentation
> > 
> > Done.
> 
> Please upload a new patch set next time, so the latest patch set in the CL is
> what actually landed.

hmm, sorry about that,

https://pdfium.googlesource.com/pdfium/+/36476923ae5eb8e9283e605f3c85ee8811c8...
+  cmd_to_run = common.DrMemoryWrapper(drmem_wrapper,
+                                      os.path.splitext(input_filename)[0])

It looks like it takes the local CL, not the last patch here.

Powered by Google App Engine
This is Rietveld 408576698