Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issue 1465223009: [heap] pause observers during mark-compact (Closed)

Created:
5 years ago by ofrobots
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] pause observers during mark-compact Inline allocations performed during mark compact aren't real allocations. They should not trigger inline-allocation-observer notifications. R=hpayer@chromium.org, ulan@chromium.org BUG= Committed: https://crrev.com/471dd3acdfc72a8cdae92982216d8cb7c36bfde7 Cr-Commit-Position: refs/heads/master@{#32566}

Patch Set 1 #

Total comments: 2

Patch Set 2 : use a scope for pausing/resuming inline allocation observers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -16 lines) Patch
M src/heap/heap.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/heap/spaces.h View 1 2 chunks +18 lines, -3 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M test/cctest/test-spaces.cc View 1 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
ofrobots
hpayer@, ulan@ PTAL.
5 years ago (2015-11-25 20:13:27 UTC) #1
Hannes Payer (out of office)
https://codereview.chromium.org/1465223009/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1465223009/diff/1/src/heap/heap.cc#newcode1388 src/heap/heap.cc:1388: new_space()->PauseInlineAllocationObservers(); A scope would be cleaner for pausing and ...
5 years ago (2015-11-26 09:55:10 UTC) #2
ofrobots
https://codereview.chromium.org/1465223009/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1465223009/diff/1/src/heap/heap.cc#newcode1388 src/heap/heap.cc:1388: new_space()->PauseInlineAllocationObservers(); On 2015/11/26 09:55:10, Hannes Payer wrote: > A ...
5 years ago (2015-12-02 06:05:31 UTC) #3
Hannes Payer (out of office)
lgtm
5 years ago (2015-12-02 08:09:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465223009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465223009/20001
5 years ago (2015-12-03 13:59:34 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 14:20:07 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-03 14:21:03 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/471dd3acdfc72a8cdae92982216d8cb7c36bfde7
Cr-Commit-Position: refs/heads/master@{#32566}

Powered by Google App Engine
This is Rietveld 408576698